Skip to content

Conversation

@slinkydeveloper
Copy link
Member

@slinkydeveloper slinkydeveloper commented Nov 19, 2020

This is done to be consistent with #289. Also deprecating the constructor to force users to use the static method

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Nov 19, 2020
@slinkydeveloper slinkydeveloper added this to the 2.0.0.CR1 milestone Nov 19, 2020
…events#289

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper force-pushed the bytes_cloud_event_data_wrap branch from 3bd2bac to 6e9fa95 Compare November 24, 2020 07:46
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me.

LGTM.

@slinkydeveloper slinkydeveloper merged commit 5037a69 into cloudevents:master Nov 24, 2020
@slinkydeveloper slinkydeveloper deleted the bytes_cloud_event_data_wrap branch November 24, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants