Skip to content

Conversation

@slinkydeveloper
Copy link
Member

Part of #125

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

@slinkydeveloper
Copy link
Member Author

Depends on #289

Copy link
Contributor

@dsyer dsyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes suggested inline.


@Configuration
public class JacksonConfiguration {
@Bean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this (Spring Boot provides it automatically).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I remove JerseyConfiguration too?

Copy link
Contributor

@dsyer dsyer Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to register the CloudEventsProvider?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CloudEventsProvider should be registered through the restful ws SPI: https://github.com/cloudevents/sdk-java/tree/master/http/restful-ws/src/main/resources/META-INF/services

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Then I guess we still need it to register the MainResource at least? It's more common in a Spring Boot app to register the instance, not the class, but in this case it doesn't matter.

Copy link
Member Author

@slinkydeveloper slinkydeveloper Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not at all expert of conventions in Spring Boot, so I can't tell which solution is best 😄 ... Should I change the registration with the instances?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salaboy
Copy link

salaboy commented Nov 20, 2020

@slinkydeveloper @dsyer this is good! and I think that is basically doing what I need as well.

@dsyer
Copy link
Contributor

dsyer commented Nov 20, 2020

@salaboy good to hear. Your PR was using Spring @RestController though, and I think we should have some support for that as well eventually. @olegz is working on a PR that has a @RestController BTW.

@salaboy
Copy link

salaboy commented Nov 20, 2020

@dsyer that's cool.. I think that if webflux is supported I am more than ok with it.. I've created the @RestController stuff to create a PR to this repo, because I was aware that not everyone was into Webflux still. I am happy to see that supported in a much cleaner way.. I believe that this is a big enabler for people to use CE.

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper merged commit cc0892a into cloudevents:master Nov 24, 2020
@slinkydeveloper slinkydeveloper modified the milestones: 2.0.0, 2.0.0.RC1 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants