Add docs for FilterableValue to rust bindings crate
#2547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
commented
Apr 3, 2025
This was referenced Apr 3, 2025
bfops
reviewed
Apr 4, 2025
gefjon
force-pushed
the
phoebe/filterable-value-docs
branch
from
1e5d251 to
cae0f61
Compare
Collaborator
|
I'm removing the auto-added review requests for the CLI folks, now that the CLI diff is gone. I hope that's correct. I don't have any helpful input into the rest of this PR. |
Centril
force-pushed
the
centril/plain-enum-as-index
branch
2 times, most recently
from
8cdac9a to
9b3758b
Compare
gefjon
added
release-1.1
and removed
release-any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added docs for
FilterableValue, and made that trait visible so that it shows up in the docs.I also added a
#[doc(hidden)]"private" supertrait bound toFilterableValue, to discourage use.API and ABI breaking changes
N/a.
Expected complexity level and risk
Testing
cargo doc --openand read the new docs, which looked good (if I do say so myself). Clicked through links and whatnot.