-
Notifications
You must be signed in to change notification settings - Fork 664
Compress the snapshot #2034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Compress the snapshot #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48b1fe2 to
61d708a
Compare
61d708a to
e31dca4
Compare
e31dca4 to
f011e18
Compare
Closed
Collaborator
|
should this still be labeled |
kim
reviewed
Apr 1, 2025
0af5cab to
025b8e5
Compare
kim
reviewed
Apr 9, 2025
031edd4 to
9ef66ae
Compare
kim
approved these changes
Apr 10, 2025
Contributor
kim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Move out from commit log compression, and instead compress on each tick, that is already long to reach
9ef66ae to
c27ac79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Compress the snapshot, using
Zstd.Closes #1592 & #1594.
API and ABI breaking changes
It could read previously uncompressed data because it will detect using
magic bytesthe compression algorithm used, if any.Because it wrap the
fileswithCompressReader/CompressWriteris transparent to the rest of the engine.Expected complexity level and risk
1
Testing
[ignored]test that using the environment variablesSNAPSHOT="path'", IDENTITY=hex` for check the compression ratio on existing data*Bench