Skip to content

Commitlog compression #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coolreader18 merged 1 commit into from
Mar 31, 2025
Merged

Commitlog compression #2504

coolreader18 merged 1 commit into from
Mar 31, 2025

Conversation

@coolreader18
Copy link
Collaborator

@coolreader18 coolreader18 commented Mar 25, 2025 •
edited
Loading

Description of Changes

Resolves #1592. Takes fs-utils/compression from #2034.

API and ABI breaking changes

Not sure which label applies, but this is a change that is not forwards-compatible once you upgrade.

Expected complexity level and risk

3 - this is a bit tricky but I'm pretty confident in this implementation.

Testing

  • commits are properly compressed to zstd format when a snapshot is taken.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

@coolreader18 coolreader18 force-pushed the noa/commitlog-compression branch from 0f513e7 to 6d8c277 Compare March 25, 2025 21:24
kim
kim reviewed Mar 26, 2025
View reviewed changes
@coolreader18 coolreader18 force-pushed the noa/commitlog-compression branch from 6d8c277 to 8339ae1 Compare March 27, 2025 20:00
@coolreader18 coolreader18 marked this pull request as ready for review March 27, 2025 20:00
@coolreader18 coolreader18 requested a review from kim March 27, 2025 20:01
@coolreader18 coolreader18 force-pushed the noa/commitlog-compression branch 2 times, most recently from b4cc1b5 to a6b262d Compare March 28, 2025 02:01
kim
kim approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@kim kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bfops bfops added the release-any To be landed in any release window label Mar 31, 2025
@coolreader18 coolreader18 force-pushed the noa/commitlog-compression branch from a6b262d to 6e4e3f6 Compare March 31, 2025 21:34
@coolreader18 coolreader18 force-pushed the noa/commitlog-compression branch from 6e4e3f6 to 0ad809b Compare March 31, 2025 21:37
@coolreader18 coolreader18 enabled auto-merge March 31, 2025 21:45
@coolreader18 coolreader18 added this pull request to the merge queue Mar 31, 2025
Merged via the queue into master with commit a5212a5 Mar 31, 2025
15 of 16 checks passed
@coolreader18 coolreader18 deleted the noa/commitlog-compression branch March 31, 2025 23:09
github-merge-queue bot pushed a commit that referenced this pull request Apr 1, 2025
@coolreader18
Followup to #2504 (#2534)
d436b1f
@coolreader18 coolreader18 mentioned this pull request Apr 1, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mamcx mamcx mamcx left review comments

@kim kim kim approved these changes

Assignees

No one assigned

Labels

release-any To be landed in any release window

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[STORAGE USE REDUCTION] Commitlog segment compression

5 participants

@coolreader18 @kim @mamcx @bfops