Pull in Updates from skeleton-generic #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user forked cisagov/scan-target-data and created a pull request, but the required GitHub Action(s) did not run. This is presumably because the user does not have Actions enabled in his or her fork. Ideally, the required Action(s) would run in cisagov/scan-target-data when a PR to merge changes back is created. Based on my reading of this link, adding the "pull_request" event type should make this happen: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-events-for-forked-repositories
…m-forked-repos Make workflow run when a PR is opened, synchronized, or reopened
Cleanup Linux instructions and add WSL references to CONTRIBUTING.md
Update actions/checkout to v2 Update formatting to match downstream children
…n_and_checkout_action Update Python and actions/checkout Versions
Update pre-commit hooks (and flip Actions cache order in workflow).
…provements/pull_in_upstream_updates
…--verbose --all-files).
… is breaking coveralls uploads.
Add comment explaining why coveralls is being pinned.
… is released which fixed the regression introduced in 1.11.0 per https://github.com/coveralls-clients/coveralls-python/releases/tag/1.11.1
mcdonnnj
requested review from
dav3r,
felddy,
jsf9k and
a team
as code owners
… verbose '--requirement'.
…ches Use Verbose pip Switches
…provements/pull_in_upstream_updates
9 tasks
mcdonnnj
pushed a commit
that referenced
this pull request
Mar 3, 2020
…ignore Add .mypy_cache to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR pulls in updates to cisagov/skeleton-generic from cisagov/skeleton-generic#33. Additionally this PR changes version pinning because as of v1.10.0
coverallssupportscoverage5.0, but a regression introduced in v1.11.0 causes issues with GitHub Actions. As a result we are no longer pinningcoverage, butcoverallshas a pin to avoid the version with a regression.💭 Motivation and Context
The latest and greatest!
🧪 Testing
Standard test suite ran with no issues.
🚥 Types of Changes
✅ Checklist