Pull in build Workflow Changes from Upstream #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect workflow if someone forks and does a pull request.
mcdonnnj
requested review from
dav3r,
felddy,
jsf9k and
a team
as code owners
mcdonnnj
deleted the
improvement/pull_build_workflow_change_from_upstream
branch
mcdonnnj
added a commit
that referenced
this pull request
Feb 12, 2020
Update pre-commit hooks (and flip Actions cache order in workflow).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This small PR pulls in changes to the
buildworkflow from cisagov/skeleton-generic.💭 Motivation and Context
A bug noticed by @jsf9k results in workflows not correctly running in GitHub Actions if an individual forks the repository and then does a pull request. This prevents required tests from running to allow for the pull request to be merged. Further information is available in cisagov/skeleton-generic#29
🧪 Testing
This was tested in the upstream pull request.
🚥 Types of Changes
✅ Checklist