Add Scripts for Bumping Versions and Tagging #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g through scripts. Update setup.py to include the semver package which is used by the bump_version.sh script.
mcdonnnj
requested review from
dav3r,
felddy,
jsf9k and
a team
as code owners
…ments-dev.txt file to better match intent.
dav3r
approved these changes
Jan 10, 2020
| echo Changing version from "$old_version" to "$new_version" | ||
| tmp_file=/tmp/version.$$ | ||
| sed "s/$old_version/$new_version/" $VERSION_FILE > $tmp_file | ||
| mv $tmp_file $VERSION_FILE |
There was a problem hiding this comment.
Since it may come up in the future and so we don't forget our past, we should probably add a brief comment here about why we do this business with the temp file (short version: Mac OS uses BSD sed - see cisagov/cyhy-mailer@283dcbf)
There was a problem hiding this comment.
That's a good point. I've added comments in 03278ca to explain.
felddy
approved these changes
Jan 10, 2020
…sion in the bump_version.sh script.
mcdonnnj
added a commit
that referenced
this pull request
Feb 11, 2020
Cleanup Linux instructions and add WSL references to CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds the
bump_version.shandtag.shscripts to allow easy version bumping and tagging for Python projects. Thesemverpackage was also added as a requirement since it is used bybump_version.sh.💭 Motivation and Context
Versions and tags are used for marking a release point, and these helper scripts are already in use to that end in some Python projects we have. I thought it would be useful to add it to
skeleton-python-libraryso that all Python projects will be able to leverage that functionality.🧪 Testing
Verified that the version was correctly retrieved with
bump_version.sh show. Since these scripts are in use in other projects I assume other functionality will work correctly.🚥 Types of Changes
✅ Checklist