Async Reset support for Atomics, FPU, and TLBroadcast #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FPU: make it work for chisel3 AsyncReset without swapping whole file to chisel3
Allows just the reset inference feature of chisel3 in Chisel._ files Apply it to LazyModules
mwachs5
changed the title
mwachs5
changed the title
|
This passed LEC on several designs. Going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
This contains workarounds for #2361
This bumps chisel to pick up fix for chipsalliance/chisel#1253 done in chipsalliance/chisel#1388
Type of change: feature request
Impact: API addition (no impact on existing code)
Development Phase: implementation
Release Notes
FPU, tilelink/Atomics, TLBroadcast are converted to be able to use chisel3
AsyncReset. This is done generally with a specific compatibility mode change vs entirely converting them to chisel3 in a new DefaultCompileOptions.NonStrictInferResetSome withReset(false.B) are added around combinational hardfloat modules in the FPU to avoid having to do this recursively in hardfloat files (hardfloat sequential modules were previously converted to chisel3 so are not an issue). Comments pointing to the linked issue #2361 are added for these workarounds so they can be deleted once hardfloat is adjusted.