fix: handle undefined variables by returning empty string #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'undefined'
- Modified getVariableValue() to use nullish coalescing operator
- Fixes issue where {{VALUE}} outputs "undefined" when no input provided
- Preserves legitimate values like empty strings, "0", and "false"
- Added comprehensive tests to prevent regression
Fixes #209
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
# [1.14.0](1.13.3...1.14.0) (2025-06-19) ### Bug Fixes * handle undefined variables by returning empty string instead of 'undefined' ([#820](#820)) ([6048ef7](6048ef7)), closes [#209](#209) * prevent crash when typing comma in VDATE syntax ([2e8939c](2e8939c)), closes [#455](#455) * replaceLinebreakInString bug with double newlines ([#752](#752)) ([1a02543](1a02543)) ### Features * add canvas template support ([#831](#831)) ([ccfd936](ccfd936)), closes [#663](#663) * add comma support in VDATE date formats ([6c65266](6c65266)) * add default values for {{VALUE:variable}} syntax ([#821](#821)) ([382294e](382294e)), closes [#569](#569) [#264](#264) [#569](#569) * **docs:** enhance documentation with improved content, modern design, and framework upgrade ([ae003f8](ae003f8)) * enable VDATE reuse with different formats ([#822](#822)) ([fe1dcac](fe1dcac)), closes [#69](#69) * enhance field suggestions with advanced filtering and smart defaults ([#826](#826)) ([7b09254](7b09254)), closes [#337](#337) [#337](#337)
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
{{VALUE}}and{{VALUE:variableName}}output the literal string "undefined" instead of an empty stringChanges
getVariableValue()incompleteFormatter.tsto use nullish coalescing operator (??)Implementation Details
The fix is a minimal one-line change that addresses the root cause:
This ensures that
nullandundefinedvalues are converted to empty strings while preserving all legitimate values including:"")"0""false"Test Plan
Related Issues
Fixes #209
🤖 Generated with Claude Code