Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaceLinebreakInString bug with double newlines #752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edongashi
Copy link
Contributor

@edongashi edongashi commented Nov 3, 2024

Replaces regex with a simple state machine.

Since there is no test infrastructure, I ran the following snippet for a sanity check:

console.log([
  "Line1\\Line2",
  "Line1\\\\Line2",
  "Line1\\tLine2",
  "Line1\\nLine2",
  "Line1\\n\\nLine2",
  "Line1\\n\\\\nLine2",
  "Line1\\n\\\\\\nLine2",
].map(replaceLinebreakInString).join('\n======\n'))

And got:

Line1\Line2
======
Line1\Line2
======
Line1\tLine2
======
Line1
Line2
======
Line1

Line2
======
Line1
\nLine2
======
Line1
\
Line2

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quickadd ✅ Ready (Inspect) Visit Preview Nov 3, 2024 2:33am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant