-
Notifications
You must be signed in to change notification settings - Fork 6
Release to maven central #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More details on the setup can be found at https://andresalmiray.com/publishing-to-maven-central-using-apache-maven/ |
Moreover, should you'd like to also post a Git release then JReleaser may be used to accomplish this task, just like it's been done for many of the Kordamp and JReleaser projects, such as https://github.com/kordamp/kordamp-maven-parent/releases/tag/v1.3.0 |
@aalmiray are you able to add reviewers to this PR? If so, I would add @afrittoli and/or @rjalander to get their attention :) |
@zaza good idea! unfortunately I can't request a review (?). Strange. |
Thanks for the PR @aalmiray, I have added people as reviewers. @afrittoli @e-backmark-ericsson: Do you know why they were not able to add reviewers? |
That's the normal behaviour according to GitHub docs https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review Even if someone is not allowed to add a reviewer, mentioning them in a comment is enough to send a notification |
@aalmiray Thank you for your contribution!! We don't have a first release of the spec yet, but hopefully we'll have it soon, so it's great to prepare in advance. I'm not very familiar with maven and its artefact publication process, so forgive the silly questions.
Apart from this, there seem to be some linter issues to be fixed before this can pass CI. @rjalander wdyt? |
The recommended way would be to store private information using GitHub secrets. Keyless signing is not yet supported by Maven nor Maven Central (the canonical repository).
Please follow the instructions at https://central.sonatype.org/publish/publish-guide/#introduction
Not really as the Maven wrapper can be bootstrapped in other ways. The wrapper JAR is the most convenient. If this is a problem I can switch it to a different option. The wrapper version is defined at
I'll take care of the lint issue and submit an update. |
@rjalander @afrittoli I've pushed an update that I hope makes the linter happy. However, the workflow requires approval once more. |
443cccd
to
e0c8e28
Compare
@rjalander @afrittoli Updated PR with latest changes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you @aalmiray for this. For the little understanding I have of Maven this looks good to me. I'll start working on getting the required credentials provisioned.
This PR address #8. Please feel free to squash all commits.
Configures the pom with minimum required elements and behavior as per the Maven Central publication guidelines.
Release may be pushed by running the "Release" workflow from the GitHub Actions UI; you must supply the given release version as an input.
The following secrets must be configured in this repository:
The chosen Sonatype user must have publication access rights to
groupId = dev.cdevents
.The public GPG key must be available at any of the following public key servers: