Cdevent merge #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjalander
reviewed
Aug 12, 2022
echo-pubsub-core/src/main/java/com/netflix/spinnaker/echo/pubsub/CDEventController.java
Outdated
Show resolved
Hide resolved
rjalander
reviewed
Aug 12, 2022
echo-pubsub-core/src/main/java/com/netflix/spinnaker/echo/pubsub/CDEventCreator.java
Outdated
Show resolved
Hide resolved
rjalander
reviewed
Aug 15, 2022
| @@ -28,6 +28,7 @@ dependencies { | |||
| implementation "com.squareup.retrofit:retrofit" | |||
| implementation "com.squareup.retrofit:converter-jackson" | |||
| implementation "com.jakewharton.retrofit:retrofit1-okhttp3-client:1.1.0" | |||
| implementation files('cdevents-sdk-java-0.0.1.jar') | |||
There was a problem hiding this comment.
This local file can be removed and used from maven repo once this PR is fixed, cdevents/sdk-java#9
rjalander
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:
Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.