Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): second revert of shotgun ammo AoE #6027

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Feb 1, 2025

Purpose of change (The Why)

AoE ammo was added without checking damage or arpen. This means Doofenshmirtz managed to add his death in a can inator to destroy THE ENTIRE TRI-STATE AREA!

This is a huge problem because AoE always hits every target inside the cone for full damage and arpen without any aiming or weapon skill involved and can easily clear out dozens of enemies. The worst offender is 40mm rounds that can immediately annihilate most enemies even within mods and do that in a massive AoE.

Describe the solution (The How)

Reverts the AoE on buckshot, flechette, and scrap shot from, but keeps it on bird shot, rat shot, and cannon shells, also dragons breath / pyrotechnic ammo. Also reverts weird damage changes.

A later PR will bring more shotshell types that will add AoE. That's out of scope here, and that's Robbie's work.

https://github.com/cataclysmbnteam/Cataclysm-BN/pull/4950/files
https://github.com/cataclysmbnteam/Cataclysm-BN/pull/5980/files

Describe alternatives you've considered

Forcing Chaos or Kheir to make shots blocked by targets so it doesn't propogate forever because I can't do that myself. Full nerf of AoE shells because of the associated bugs. Having a form of AoE that splits into projectiles so buckshot is actually 8 smaller rounds that hit within the cone.

Testing

It'll load.

Additional context

BEHOLD MY NERF INATOR

https://www.youtube.com/watch?v=mHtq-mlzY7s

Checklist

Mandatory

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 1, 2025
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You made 20ga paper shot equal in damage to regular 12 gauge. I'd suggest having 12 gauge be 50 and 20ga be 40.
  2. If you're going to nerf damage, you NEED to check for other ammotypes that inherit from ammo you changed. This nerfs the everloving shit out of slugs for example.
  3. You forgot .410. 30 is good I guess awawa

@RoyalFox2140
Copy link
Collaborator Author

image
410 was nerfed in the previous PR, but the rest ill have to look at

@RoyalFox2140 RoyalFox2140 marked this pull request as draft February 1, 2025 00:43
@RoyalFox2140 RoyalFox2140 marked this pull request as ready for review February 1, 2025 00:56
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight. I hate to do this but to be honest this code still really has needed more time in the oven for years at this point, stupid problems with it just keep coming up.

@chaosvolt chaosvolt changed the title feat(balance): Thermonuclear nerf to AoE shotgun ammo feat(balance): second revert of shotgun ammo AoE Feb 1, 2025
@RoyalFox2140 RoyalFox2140 merged commit b77a71f into cataclysmbnteam:main Feb 1, 2025
11 of 14 checks passed
@RoyalFox2140 RoyalFox2140 deleted the Fuck-your-fun branch February 1, 2025 05:02
scarf005 added a commit that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants