-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance): second revert of shotgun ammo AoE #6027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You made 20ga paper shot equal in damage to regular 12 gauge. I'd suggest having 12 gauge be 50 and 20ga be 40.
- If you're going to nerf damage, you NEED to check for other ammotypes that inherit from ammo you changed. This nerfs the everloving shit out of slugs for example.
You forgot .410.30 is good I guess awawa
This reverts commit 8f73ee5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aight. I hate to do this but to be honest this code still really has needed more time in the oven for years at this point, stupid problems with it just keep coming up.
Purpose of change (The Why)
AoE ammo was added without checking damage or arpen. This means Doofenshmirtz managed to add his death in a can inator to destroy THE ENTIRE TRI-STATE AREA!
This is a huge problem because AoE always hits every target inside the cone for full damage and arpen without any aiming or weapon skill involved and can easily clear out dozens of enemies. The worst offender is 40mm rounds that can immediately annihilate most enemies even within mods and do that in a massive AoE.
Describe the solution (The How)
Reverts the AoE on buckshot, flechette, and scrap shot from, but keeps it on bird shot, rat shot, and cannon shells, also dragons breath / pyrotechnic ammo. Also reverts weird damage changes.
A later PR will bring more shotshell types that will add AoE. That's out of scope here, and that's Robbie's work.
https://github.com/cataclysmbnteam/Cataclysm-BN/pull/4950/files
https://github.com/cataclysmbnteam/Cataclysm-BN/pull/5980/files
Describe alternatives you've considered
Forcing Chaos or Kheir to make shots blocked by targets so it doesn't propogate forever because I can't do that myself. Full nerf of AoE shells because of the associated bugs. Having a form of AoE that splits into projectiles so buckshot is actually 8 smaller rounds that hit within the cone.
Testing
It'll load.
Additional context
BEHOLD MY NERF INATOR
https://www.youtube.com/watch?v=mHtq-mlzY7s
Checklist
Mandatory
closes #1234
in Summary of the PR so it can be closed automatically.main
so it won't cause conflict when updatingmain
branch later.