Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give No Hope the e #3246

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Give No Hope the e #3246

merged 1 commit into from
Sep 24, 2023

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Bugfixes "Fix No Hope palette override lacking terrain that caused the game to error on load"

Purpose of change

In another fine example of "why do we even have that lever?" No Hope includes a full oiverride for some map palettes, including one recently touched by #3224 and this was why the buildbot was cryptically exploding.

Fixes this thing:
image

Describe the solution

Added missing terrain defs to No Hope's version of parking_palette.

Describe alternatives you've considered

  1. Removing palette overrides because it's really weird that No Hope overrides SO MUCH STUFF
  2. Also implementing and testing working elevators in the No Hope version but I assume that is against the spirit of the mod. Also effort and it's past midnight and I need to do stuff tomorrow weh

Testing

Checked affected file for syntax and lint errors.

Additional context

image

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Sep 24, 2023
@scarf005 scarf005 merged commit fd9e894 into cataclysmbnteam:upload Sep 24, 2023
@chaosvolt chaosvolt deleted the e branch September 24, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants