Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parking garage elevator repair #3224

Merged

Conversation

Zlorthishen
Copy link
Contributor

@Zlorthishen Zlorthishen commented Sep 23, 2023

SUMMARY

SUMMARY: Content "Makes parking garage elevators work"

Purpose of change

Makes the elevators in parking garages more usable

Describe the solution

adds the elevator control and switch to parking garages

Describe alternatives you've considered

keeping things stagnant isn't an option

Testing

made and killed many different characters to see how the parking garage spawns

Additional context

GIF 9-23-2023 11-45-40 AM

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Sep 23, 2023
@scarf005 scarf005 self-assigned this Sep 23, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit inconvenient choosing between winch and elevator control but very useful nonetheless.

2023-09-24_02-35-43.mp4

@scarf005 scarf005 merged commit 4b92835 into cataclysmbnteam:upload Sep 23, 2023
@Zlorthishen Zlorthishen deleted the parking-garage-elevator-repair branch September 23, 2023 17:54
@chaosvolt
Copy link
Member

So this is causing the buildbot to complain about e not having terrain assigned but:

  1. Why the fuck isn't it erroring on load and only the buildbot?
  2. Why is it complaining at all when e is clearly and overtly set to be set to spawn elevator controls?
  3. Why only on line 120, in a mapgen entry that uses the same palette all the other ones in the file use?

@chaosvolt chaosvolt mentioned this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants