Improve organization of achivements, port skill achievements

[chaosvolt]

Summary

SUMMARY: Content "Port over skill achievements, use consistent capitalization and category indicators in achievement names"

Purpose of change

Figured I can work on porting over a few more easy achievements that don't yet require many code changes to support (this turns out to be wrong, see below). Along the way I also decided it'd be good to add a general indication of what sort of achievement each is in the name (similar to Arcana and Cataclysm++ preceding the title with mod name), so they have a cleaner organization on the achievement screen.

Dependent upon #2719 to work right, that PR will need to be merged first.

Describe the solution

Ported over skill achievements, minus skills BN lacks. The level 7 achievements instead set to trigger on level 5 so it's a marker of mid-level skill to space them out better, picked a less masturbatory name for the level 10 computer skill achievement. Also corrected any typos from PR JSON I found along the way. Formatting is also now fixed up thanks to Kheir.

Also decided to go a bit easier on achievement names/descriptions that're just namedropping some random person outright, and accordingly rewrote a couple of descriptions in turn. Though The Doctor Is In might still be read as a reference (well, would if time travel was a skill), and Captain of The R-MCC Landship does reference a famous meme deathmobile by a one @EkarusRyndren but otherwise...

Also added the if statement in Character::practice that ensures the event triggers, to quote their reasoning:

Achievements do check for player being player, but that's being done on json level and technically can be omitted, so I'm not taking any chances. That might sound like an overkill but I'd rather have it this way, then having someone in the future scratching their head why some non-player event didn't trigger.

From what I found in JSON, it seems this is indeed important for it to work, but this needs Kheir's fixes to fix all the weird shit going on in the underlying code.

And in addition to all that, made capitalization consistent for achievement names, and added preceding category tags such as [Combat], [Skill], and so on, along with converting all names to use strings.

And also misc, updated one case of an achievement name making a pun that depends on the game name involving dark days.

Describe alternatives you've considered

Giving up and going to bed. :<

Testing

1. Checked out Kheir's branch for fixing up achievement code and dropped my JSON changes into it.
2. Compiled and load-tested.
3. Started up a character with 9 unarmed skill, correctly start off with the level-5 achievement obtained. Confirmed that the level-10 achievement is visible too.
4. Debugged in Fast Learner, Beast threshold, Apex Predator (so it doesn't take forever to skill-grind), and summoned a debug monster.
5. Hammered at it a while until unarmed level reached 10, achievement get.
6. Restarted test with a zero-skill debugged in Fast Reader, 9001 int, and 101 Crafts for Beginners.
7. Read until level-up, confirmed I did not get an achievement just for obtaining level 1.
8. Press-gang companion NPC into joining me, debugged their fabrication skill to level 9 and int to 9001, set my int back to normal and fabrication up to 5. Confirmed this does not adjust skill since done in dubug-only.
9. Read The Art of Japanese Armormaking until they leveled up instead of me, confirmed this does not trigger any achievements I don't deserve.
10. Kept on reading until I hit level 6, confirmed this retroactively unfucked the level-5 achievement previously softlocked by debugging.

With Kheir's prerequiste PR, the weird behavior I discovered during the original test is all entirely fixed up.

Additional context

Source PR: "Skill based achievements" by @nexusmrsep: CleverRaven/Cataclysm-DDA#41657

I've tested DDA and yeah, at present skill achievements softlock over there too.

[chaosvolt]

So, after further testing, the problem has multiple facets to it:

1. First, Game::Start_game needs a way to even check whether to send the correct events should you start with a given level of skill. I've included a change to game.cpp that does this, barring the additional complications below.
2. When the above successfully triggers (it doesn't always, see point three), it correctly marks the event as triggers but for whatever reason when called this early the achievement itself isn't considered complete:
   
3. And finally we get to the other big flaw, and what I noted in the PR OP to be functionally the main root problem here: you don't even get the event triggering successfully if you start with MORE skill than required, it only triggers if you start with EXACTLY the target skill level. This can be trivially tested in both BN and DDA by starting as a black belt, with 8 in combat skills you'll start off having effectively softlocked the level 5 (BN) or 7 (DDA) achievements for those skills.

[chaosvolt]

So I'm still looking at this and I feel like it'd legit just be better to say "fuck it" and go with the option where the level-5 achivements are self-hidden, avoiding the issue of chargen letting you softlock achievements by just only making them visible if you earn them via in-game means.

Reasons being:

1. I already the mutation threshold achievements to self-hidden for the explicit reason that literally only one of them will ever be obtainable in normal gameplay, so having the rest there sitting there mocking the player seems kinda pointless. Therefore, hiding achievements for the sake of ensuring you can't be in a situation where the achievement shows as still being obtainable while in fact being unobtainable already has a precedent set for it/.
2. Having them visible from game start doesn't really add any player-nudge value, the skill being on their @ screen is already all the nudge the player needs to try and level up a skill.
3. As noted, DDA already happily uses skill achievements even with it being easy to softlock them just be starting with 7+ skill. If it's good enough for them, then surely adjusting it so the JSON at least makes the softlock itself a non-issue is still an improvement.

[chaosvolt]

I've decided to go the route of having the level-5 achievements self-hidden for the above reasons.

[scarf005]

created a new world with event bus enabled, but i was unable to find any achievements. could you help me setting up achievement correctly?

[chaosvolt]

created a new world with event bus enabled, but i was unable to find any achievements. could you help me setting up achievement correctly?

Oh that's weird. Make sure you've closed the game, re-opened, then created the new world after enabling event bus? o.O

Note that event bus is enabled by default in the options, too.

[KheirFerrum]

created a new world with event bus enabled, but i was unable to find any achievements. could you help me setting up achievement correctly?

This looks like it might be due to fuckery in game.cpp. I had the same issue when I reverted some of Chaos' older commits to play around. Up to date branch has no such issues however, so perhaps your branch is out of date.

[chaosvolt]

Let me update from upstream and see if that fixes it.

[scarf005]

not sure why but Do-It-Yourselfer does not show which skill triggers it.

---

Followed given testing steps and confirmed they worked as written

LGTM

• tip: setting int to 99999 makes upping a skill from 9 to 10 take less than a minute