Add more achievement variable checks #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
JSON
KheirFerrum
force-pushed
the
add-more-achievement-variables
branch
from
15a8483 to
d98355a
Compare
Instead of relying on the event like an idiot, reference player skill directly and update when skill gain event triggers instead.
For @chaosvolt to sample
KheirFerrum
force-pushed
the
add-more-achievement-variables
branch
from
d98355a to
b18949a
Compare
KheirFerrum
force-pushed
the
add-more-achievement-variables
branch
from
b18949a to
ab285d8
Compare
KheirFerrum
force-pushed
the
add-more-achievement-variables
branch
from
ab285d8 to
9bc1f2f
Compare
chaosvolt
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
- Checked out this branch and dropped my JSON changes from the skill achievements PR into it.
- Compiled and load-tested.
- Started up a character with 9 unarmed skill, correctly start off with the level-5 achievement obtained. Confirmed that the level-10 achievement is visible too.
- Debugged in Fast Learner, Beast threshold, Apex Predator (so it doesn't take forever to skill-grind), and summoned a debug monster.
- Hammered at it a while until unarmed level reached 10, achievement get.
- Restarted test with a zero-skill debugged in Fast Reader, 9001 int, and 101 Crafts for Beginners.
- Read until level-up, confirmed I did not get an achievement just for obtaining level 1.
- Press-gang companion NPC into joining me, debugged their fabrication skill to level 9 and int to 9001, set my int back to normal and fabrication up to 5. Confirmed this does not adjust skill since done in dubug-only.
- Read The Art of Japanese Armormaking until they leveled up instead of me, confirmed this does not trigger any achievements I don't deserve.
- Kept on reading until I hit level 6, confirmed this retroactively unfucked the level-5 achievement previously softlocked by debugging.
So this PR can be tested on it's own Co-Authored-By: Chaosvolt <chaosvolt@users.noreply.github.com> Co-Authored-By: nexusmrsep <39925111+nexusmrsep@users.noreply.github.com>
KheirFerrum
force-pushed
the
add-more-achievement-variables
branch
from
9bc1f2f to
b583310
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Add more achievement variable checks."
Purpose of change
Looked at #2613 and hated how it hacked around the event bus to implement skill checking. Also wanted to solve Chaos' issue with skill softlock and improve the UI display.
Describe the solution
New field in achievements that allows you to set skill(s) to check. Sadly right now the only way to check multiple skills is to set the listener to update on every skill level up.
Describe alternatives you've considered
Make each level up send a number of events from level 0 to current level to trigger all the fucking achievements.
Testing
Additional context