-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standard house palette update - bedside table #1909
standard house palette update - bedside table #1909
Conversation
adding house_34
add new house
added furniture -- nightstand
Looks like only one of the houses changed to use the new symbol have a floor for it set as well. |
Strangely enough, this is really similar to the issue I'm having in adding these houses to CDDA as well. In that case, the symbol in question is already an established entry in the standard house palette, and it spawns perfectly in game when I add the symbol to house layout (and call the standard palette), but Github isn't happy about it, saying it's undefined. Same issue here, as I've defined the symbol in BN's standard palette, which is called by the updated house entries on both the basement and 2nd floor levels that are throwing the error. From what I can tell, either:
This might be an issue with calling multiple palettes in the same house layout and Github not appreciating that, or it could be that GitHub doesn't like these weirder symbols ("" in BN or "" in CDDA), even though the games recognize them just fine. Definitely open to suggestions on this one. |
Same as with #1914, it's caused by No_Hope overwriting the |
Thanks, I'll try and fix this when I'm home. EDIT: Yep, that did it! |
Summary
SUMMARY: Content "added standard house palette furniture entry - nightstand"
Purpose of change
adding an entry for a bedside table or nightstand to standard house palette for all of my upcoming house additions.
Describe the solution
added entry to house palette. Changed corresponding entry in 2StoryModern03 to reflect the nighstand change on basement level and 2nd floor.
Describe alternatives you've considered
not adding the entry
Testing
added, linted, spawned 2storymodern03 ingame, it works.
Additional context