Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installation instructions more prominent in the documentation for users #107

Closed
3 tasks done
kinow opened this issue Feb 1, 2023 · 4 comments
Closed
3 tasks done
Assignees
Labels
joss Issues related to the JOSS paper submission

Comments

@kinow
Copy link

kinow commented Feb 1, 2023

Hi,

For the JOSS paper review, I looked for the installation instructions of Carnival.

Initially it wasn't clear whether it was published to Maven Central or not, whether I should user Docker, etc.

I think now I've found the docs to install it, under the getting started page.

@kinow
Copy link
Author

kinow commented Feb 1, 2023

This issue is related to the final pending items in my review

Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
Functionality: Have the functional claims of the software been confirmed?
Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?

@th5 th5 added the joss Issues related to the JOSS paper submission label Feb 3, 2023
hjwilli added a commit that referenced this issue May 11, 2023
References #107
@hjwilli
Copy link
Collaborator

hjwilli commented May 12, 2023

Hi @kinow, I believe these issues have now all been addressed, and the documentation on how to use carnival in a project should be clearer:
https://carnival-data.github.io/carnival/#using-carnival

Please let us know if this is sufficient!

@kinow
Copy link
Author

kinow commented May 12, 2023

Thank you @hjwilli ! I will start the review process again over this weekend. Thank you!

@kinow
Copy link
Author

kinow commented May 14, 2023

The installation/usage instructions look good to me. I've used Groovy+Grapes in the past, and I believe users and readers would be able to read Grapes' docs (if needed) and follow the steps in the new docs. Thanks @hjwilli ! Closing.

@kinow kinow closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
joss Issues related to the JOSS paper submission
Projects
None yet
Development

No branches or pull requests

4 participants