fix(overflow-menu): correct hover color #5513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 5feeb03 |
|
Deploy preview for carbon-components-react ready! Built with commit 1761e46 https://deploy-preview-5513--carbon-components-react.netlify.com |
tw15egan
approved these changes
Mar 3, 2020
tw15egan
requested review from
a team and
designertyler
and removed request for
a team
|
Deploy preview for carbon-components-react ready! Built with commit 5feeb03 https://deploy-preview-5513--carbon-components-react.netlify.com |
emyarod
approved these changes
Mar 3, 2020
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Mar 10, 2020
Co-authored-by: TJ Egan <tw15egan@gmail.com>
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the hover color of the overflow menu trigger.
It was previously changed in #4270 to account for the use in data tables (#3210).
When used standalone the hover color is too dark though. This is especially noticeable when used next to icon buttons.
Changelog
New
$hover-selected-uifor overflow menus used in data tablesChanged
$hover-selected-uito$hover-uiTesting / Reviewing