Skip to content

[Data table] Multiple styling bugs #3210

Closed
@shixiedesign

Description

All themes

1. Header row has extra border bottom. No border until the row immediately underneath header is selected.

image

2. Zebra row has wrong color

Correct zebra row background colors are:
Odd row background: $field-01 at 40% opacity
Even row background: $field-01

Current

image

Current dark theme zebra is all row colors wrong ⚠️

image
image

Should be
image

Dark themes only

1. Overflow menu hover background wrong

Should be using token $hover-selected-ui which is gray 70 hover in G90 theme

White theme Gray 10 theme Gray 90 theme Gray 100 theme
gray-20 hover #cacaca gray-20 hover #cacaca gray-70 hover #656565 gray-80 hover #4c4c4c

Current:

image

Should be:

image

image

2. Overflow menu not using correct theme

For token spec, reference : #3213

Current:

image

Should be:

image

3. Setting (dependent on overflow?) menu is not getting the token assignment too

image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions