Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overflow-menu): update trigger's hover color #4270

Merged

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Oct 9, 2019

Refs #3210.

Changelog

Changed

  • The hover color of overflow menu's trigger button.

Testing / Reviewing

Testing should make sure our overflow menu is not broken.

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for the-carbon-components ready!

Built with commit 668d729

https://deploy-preview-4270--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for carbon-components-react ready!

Built with commit 668d729

https://deploy-preview-4270--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for carbon-elements failed.

Built with commit 668d729

https://app.netlify.com/sites/carbon-elements/deploys/5da9021b79a82f00080e40f7

@jnm2377 jnm2377 requested a review from designertyler October 9, 2019 14:18
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, pending design review

image

image

@jnm2377
Copy link
Contributor

jnm2377 commented Oct 10, 2019

I'll defer to design on this one. I am noticing that now, when you select a row and then hover on the overflow menu, there is no noticeable hover difference bc it's the same color as the row (that's what the $hover-selected-ui is for). So I'm not sure if overflow menu hover should be this color. I remember discussing this with @designertyler when I was working on data table but we didn't really discuss other options.

@designertyler
Copy link
Contributor

We lose the overflow hover state on selected rows now that they are the same color. Is it possible to have a different overflow hover state for when the row is selected?

It's getting lost on selected rows since they are the same color.
Oct-10-2019 15-10-43

@asudoh
Copy link
Contributor Author

asudoh commented Oct 15, 2019

@designertyler Thank you for reviewing - Any ideas (e.g. choice of theme token) wrt what the hover color of overflow menu's trigger button on selected rows? CC @shixiedesign

@designertyler
Copy link
Contributor

I'd suggest using the row's original selected color for the overflow menu's hover when it's on a selected row. This means the overflow menu's hover goes lighter for the 4 themes.

Designers chime in if this isn't what we want.

White theme Gray 10 theme Gray 90 theme Gray 100 theme
Selected row's overflow menu hover gray-20 #e0e0e0 gray-20 #e0e0e0 gray-70 #525252 gray-80 #393939

image

@asudoh
Copy link
Contributor Author

asudoh commented Oct 17, 2019

Thanks @designertyler for the updated spec! Fixed.

@asudoh asudoh merged commit 1865b93 into carbon-design-system:master Oct 18, 2019
@asudoh asudoh deleted the overflow-menu-trigger-hover branch October 18, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants