-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(overflow-menu): update trigger's hover color #4270
fix(overflow-menu): update trigger's hover color #4270
Conversation
Deploy preview for the-carbon-components ready! Built with commit 668d729 https://deploy-preview-4270--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 668d729 https://deploy-preview-4270--carbon-components-react.netlify.com |
Deploy preview for carbon-elements failed. Built with commit 668d729 https://app.netlify.com/sites/carbon-elements/deploys/5da9021b79a82f00080e40f7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to design on this one. I am noticing that now, when you select a row and then hover on the overflow menu, there is no noticeable hover difference bc it's the same color as the row (that's what the |
@designertyler Thank you for reviewing - Any ideas (e.g. choice of theme token) wrt what the hover color of overflow menu's trigger button on selected rows? CC @shixiedesign |
I'd suggest using the row's original selected color for the overflow menu's hover when it's on a selected row. This means the overflow menu's hover goes lighter for the 4 themes. Designers chime in if this isn't what we want.
|
On selected row.
Thanks @designertyler for the updated spec! Fixed. |
Refs #3210.
Changelog
Changed
Testing / Reviewing
Testing should make sure our overflow menu is not broken.