fix: update svg packages, migrate metadata, lazy load svg components #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpicone
requested review from
a team,
sstrubberg and
jnm2377
and removed request for
a team
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/carbon-design-system/carbon-website/gzq67vawp |
|
It works, but the animations around hover effects on Chrome are glitchy |
jnm2377
approved these changes
Mar 4, 2020
sstrubberg
approved these changes
Mar 4, 2020
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
…rbon-design-system#970) * fix: update svg packages, migrate metadata, lazy load svg components * fix: friendlyName * feat: use loadable * feat: add slight fade in * fix: remove manual bundle splitting * feat: use intersection observer to load icons dynamically * fix: perf enhancements * fix: try and force first category visible * feat: flatten icons and alphabatize icons and pictograms * ffix: dedup deps * fix: husky warning * fix: sort dropdown * chore: update theme * fix: pictogram sort Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com>
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
…rbon-design-system#970) * fix: update svg packages, migrate metadata, lazy load svg components * fix: friendlyName * feat: use loadable * feat: add slight fade in * fix: remove manual bundle splitting * feat: use intersection observer to load icons dynamically * fix: perf enhancements * fix: try and force first category visible * feat: flatten icons and alphabatize icons and pictograms * ffix: dedup deps * fix: husky warning * fix: sort dropdown * chore: update theme * fix: pictogram sort Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.