Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): update carbon to v10.10.0-rc.2 #947

Closed
wants to merge 8 commits into from
Closed

chore(release): update carbon to v10.10.0-rc.2 #947

wants to merge 8 commits into from

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Feb 25, 2020 •
edited
Loading

Update website to v10.10.0-rc.2 of Carbon.

Changelog

New

Changed

  • Update website to v10.10.0-rc.2 of Carbon

Removed

@joshblack joshblack requested review from a team, vpicone and sstrubberg and removed request for a team February 25, 2020 18:32
@vercel
Copy link

vercel bot commented Feb 25, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/carbon-website/qp2k656x4
✅ Preview: https://carbon-website-git-fork-joshblack-release-v10100.carbon-design-system.now.sh

@sstrubberg sstrubberg self-requested a review February 26, 2020 15:35
@sstrubberg
Copy link
Member

Looks like the build is error'ing out.

@vpicone
Copy link
Contributor

vpicone commented Feb 28, 2020

@joshblack did we remove any readme content for the code component? Weird error :/

@tw15egan
Copy link
Collaborator

@vpicone We removed most of the old outdated documentation files that hadn't been updated since like v6/v7 and before we were using mdx files. If we want to keep that information up to date we can move it to the website side of things rather than in the component package.

carbon-design-system/carbon#5277
carbon-design-system/carbon#5237

I can throw up a PR for the website that removes the documentation blocks.

vpicone
vpicone suggested changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@vpicone vpicone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the icon library is broken: https://carbon-website-p2hv9r0zo.now.sh/guidelines/icons/library

@joshblack
Copy link
Contributor Author

@vpicone right, this is due to the metadata changes correct?

@vpicone
Copy link
Contributor

vpicone commented Feb 28, 2020

@joshblack ah right, I have a branch to handle those changes somewhere 🕵️‍♂️

@vercel vercel bot requested a deployment to Preview March 2, 2020 15:12 Abandoned
@vpicone
Copy link
Contributor

vpicone commented Mar 3, 2020

Gonna close this in favor of #970

Grats on the release!

@vpicone vpicone closed this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpicone vpicone vpicone requested changes

@sstrubberg sstrubberg sstrubberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshblack @sstrubberg @vpicone @tw15egan