Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update svg packages, migrate metadata, lazy load svg components #970

Merged
merged 17 commits into from
Mar 5, 2020
Merged

fix: update svg packages, migrate metadata, lazy load svg components #970

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6a5dc86
fix: update svg packages, migrate metadata, lazy load svg components
vpicone Mar 2, 2020
dead136
fix: friendlyName
vpicone Mar 2, 2020
91d922f
feat: use loadable
vpicone Mar 2, 2020
f22312e
feat: add slight fade in
vpicone Mar 3, 2020
e80d318
fix: remove manual bundle splitting
vpicone Mar 3, 2020
aa6cfb6
feat: use intersection observer to load icons dynamically
vpicone Mar 3, 2020
64d9ed3
fix: perf enhancements
vpicone Mar 4, 2020
898a178
fix: try and force first category visible
vpicone Mar 4, 2020
7ce109d
Merge branch 'master' into svg-metadata-update
sstrubberg Mar 4, 2020
db2f5ef
feat: flatten icons and alphabatize icons and pictograms
vpicone Mar 4, 2020
f67d468
Merge branch 'svg-metadata-update' of github.com:vpicone/carbon-websi…
vpicone Mar 4, 2020
e760cf4
ffix: dedup deps
vpicone Mar 4, 2020
40840d1
fix: husky warning
vpicone Mar 4, 2020
9227fb2
fix: sort dropdown
vpicone Mar 4, 2020
9fb85aa
chore: update theme
vpicone Mar 5, 2020
5f2a6b7
fix: pictogram sort
vpicone Mar 5, 2020
1459ebd
Merge branch 'master' into svg-metadata-update
vpicone Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: sort dropdown
  • Loading branch information
@vpicone
vpicone committed Mar 4, 2020
commit 9227fb2d98bed7adabe47bcafc75528c0bacb155
8 changes: 5 additions & 3 deletions plugins/gatsby-theme-carbon-svgs/components/IconLibrary/IconLibrary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ const IconLibrary = () => {
}, []);

setCategoryList(
iconCategoryMetadata.flatMap(({ subcategories }) =>
subcategories.flatMap(({ name }) => name)
)
iconCategoryMetadata
.flatMap(({ subcategories }) =>
subcategories.flatMap(({ name }) => name)
)
.sort()
);

setCategoriesLoaded(true);
Expand Down
2 changes: 1 addition & 1 deletion plugins/gatsby-theme-carbon-svgs/components/PictogramLibrary/PictogramLibrary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const IconLibrary = () => {
[]
);

setCategoryList(pictogramCatagoryMetadata.map(({ name }) => name));
setCategoryList(pictogramCatagoryMetadata.map(({ name }) => name)).sort();
setCategoriesLoaded(true);

setPictogramComponents(pictogramArray);
Expand Down