Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix integration tests in track/2.31 #176

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix integration tests in track/2.31 #176

merged 2 commits into from
Dec 11, 2023

Commits on Dec 8, 2023

  1. fix integration tests for OIDC in Charmed Kubeflow 1.7+ (#174) 

    refactors the integration test CI to:
* use the latest/edge version of oidc-gatekeeper
* provide oidc-gatekeeper with the public-url config during setup rather than during web browsing.  This is required because the oidc-gatekeeper v1.7+ will block the charm without this setting, and also because it makes more sense then changing oidc-gatekeeper settings in the fixture for a later test

Context: previously, the integration tests here incorrectly pinned OIDC to that from charmed kubeflow 1.4, which is not how we want our main branch testing to work.
    @ca-scribner
    ca-scribner committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    258b28c View commit details
    Browse the repository at this point in the history

  2. pin CI to dependencies this branch was released to 

    Pins the charms used by integration tests as dependencies to their stable channel at time of release of this track, not to `latest/stable` which is expected to change over time.
    @ca-scribner
    ca-scribner committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    44bbdfb View commit details
    Browse the repository at this point in the history