fix integration tests for OIDC in Charmed Kubeflow 1.7+ #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactors the integration test CI to: * use the latest/edge version of oidc-gatekeeper * provide oidc-gatekeeper with the public-url config during setup rather than during web browsing. This is required because the oidc-gatekeeper v1.7+ will block the charm without this setting, and also because it makes more sense then changing oidc-gatekeeper settings in the fixture for a later test Context: previously, the integration tests here incorrectly pinned OIDC to that from charmed kubeflow 1.4, which is not how we want our main branch testing to work.
ca-scribner
force-pushed
the
KF-5107-fix-integration-test-for-new-oidc
branch
from
e52dea6
to
647ba93
Compare
orfeas-k
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
That's super weird that we ran integration tests with an old version of the charm for so long. Great catch on noticing that. Thank you @ca-scribner
ca-scribner
added a commit
that referenced
this pull request
Dec 8, 2023
refactors the integration test CI to: * use the latest/edge version of oidc-gatekeeper * provide oidc-gatekeeper with the public-url config during setup rather than during web browsing. This is required because the oidc-gatekeeper v1.7+ will block the charm without this setting, and also because it makes more sense then changing oidc-gatekeeper settings in the fixture for a later test Context: previously, the integration tests here incorrectly pinned OIDC to that from charmed kubeflow 1.4, which is not how we want our main branch testing to work.
ca-scribner
added a commit
that referenced
this pull request
Dec 8, 2023
refactors the integration test CI to: * use the latest/edge version of oidc-gatekeeper * provide oidc-gatekeeper with the public-url config during setup rather than during web browsing. This is required because the oidc-gatekeeper v1.7+ will block the charm without this setting, and also because it makes more sense then changing oidc-gatekeeper settings in the fixture for a later test Context: previously, the integration tests here incorrectly pinned OIDC to that from charmed kubeflow 1.4, which is not how we want our main branch testing to work.
kimwnasptd
pushed a commit
that referenced
this pull request
Dec 11, 2023
* fix integration tests for OIDC in Charmed Kubeflow 1.7+ (#174) refactors the integration test CI to: * use the latest/edge version of oidc-gatekeeper * provide oidc-gatekeeper with the public-url config during setup rather than during web browsing. This is required because the oidc-gatekeeper v1.7+ will block the charm without this setting, and also because it makes more sense then changing oidc-gatekeeper settings in the fixture for a later test Context: previously, the integration tests here incorrectly pinned OIDC to that from charmed kubeflow 1.4, which is not how we want our main branch testing to work. * pin CI to dependencies this branch was released to Pins the charms used by integration tests as dependencies to their stable channel at time of release of this track, not to `latest/stable` which is expected to change over time.
kimwnasptd
pushed a commit
that referenced
this pull request
Dec 12, 2023
* fix integration tests for OIDC in Charmed Kubeflow 1.7+ (#174) refactors the integration test CI to: * use the latest/edge version of oidc-gatekeeper * provide oidc-gatekeeper with the public-url config during setup rather than during web browsing. This is required because the oidc-gatekeeper v1.7+ will block the charm without this setting, and also because it makes more sense then changing oidc-gatekeeper settings in the fixture for a later test Context: previously, the integration tests here incorrectly pinned OIDC to that from charmed kubeflow 1.4, which is not how we want our main branch testing to work. * pin CI to dependencies this branch was released to Pins the charms used by integration tests as dependencies to their stable channel at time of release of this track, not to `latest/stable` which is expected to change over time. * use rock for dex 2.31 uses rock built from https://github.com/canonical/dex-auth-rocks/blob/track/2.31.2/dex/rockcraft.yaml --------- Co-authored-by: Orfeas Kourkakis <orfeas.kourkakis@canonical.com>
ca-scribner
added a commit
that referenced
this pull request
Jan 29, 2024
refactors the integration test CI to: * use the latest/edge version of oidc-gatekeeper * provide oidc-gatekeeper with the public-url config during setup rather than during web browsing. This is required because the oidc-gatekeeper v1.7+ will block the charm without this setting, and also because it makes more sense then changing oidc-gatekeeper settings in the fixture for a later test Context: previously, the integration tests here incorrectly pinned OIDC to that from charmed kubeflow 1.4, which is not how we want our main branch testing to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors the integration test CI to:
Context: previously, the integration tests here incorrectly pinned OIDC to that from charmed kubeflow 1.4, which is not how we want our main branch testing to work.