fix integration tests in track/2.31 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ca-scribner
commented
Dec 8, 2023
•
ca-scribner
commented
- cherry-picks a fix for the integration tests from main, enabling using OIDC versions of 1.7+
- pins integration tests dependencies to the versions required for this release, not latest/stable
refactors the integration test CI to: * use the latest/edge version of oidc-gatekeeper * provide oidc-gatekeeper with the public-url config during setup rather than during web browsing. This is required because the oidc-gatekeeper v1.7+ will block the charm without this setting, and also because it makes more sense then changing oidc-gatekeeper settings in the fixture for a later test Context: previously, the integration tests here incorrectly pinned OIDC to that from charmed kubeflow 1.4, which is not how we want our main branch testing to work.
Pins the charms used by integration tests as dependencies to their stable channel at time of release of this track, not to `latest/stable` which is expected to change over time.
ca-scribner
changed the title
ca-scribner
changed the title
Merged
orfeas-k
approved these changes
Dec 11, 2023
orfeas-k
deleted the
KF-5091-cherry-pick-integration-fix-to-track-2.31
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.