feature: [cawemo-migration] Add script to migrate from Cawemo to Web Modeler #329

christian-konrad · 2023-07-21T14:26:16Z

Add script to migrate from Cawemo to Web Modeler

Description

Solves #328

Testing your changes

Manual testing against Cawemo and Web Modeler SaaS
There is no API for Cawemo to create new files, hence automated tests can't be written

Types of changes

Bug fix (non-breaking change which fixes an existing open issue)
New feature (non-breaking change which adds functionality to an extension)
Breaking change (fix or feature that would cause existing functionality of an extension to change)
Documentation update (changes made to an existing piece of documentation)

Checklist:

My code adheres to the syntax used by this extension.
My pull request requires a change to the documentation.
I have updated the documentation accordingly.
I have read the Camunda Community Hub documentation.
I have read the Pull Request Process documentation.
I have added or suggested tests to cover my changes suggested in this pull request.
All new and existing CI/CD tests passed.
I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

github-actions · 2023-07-21T14:34:57Z

Test Results

  26 files +  26   26 suites +26 2m 47s ⏱️ + 2m 47s
214 tests +214 214 ✔️ +214 0 💤 ±0 0 ❌ ±0
332 runs +332 332 ✔️ +332 0 💤 ±0 0 ❌ ±0

Results for commit 0ccd12c. ± Comparison against base commit 0eb6c15.

♻️ This comment has been updated with latest results.

jfriedenstab

Nice work! 🚀 A few smaller things I've noticed though.

By the way, the migration does not seem to work yet for DMN diagrams (400 Bad Request is returned from Web Modeler).

cawemo-to-web-modeler-migration/README.md

cawemo-to-web-modeler-migration/migrate-cawemo-to-web-modeler.sh

jfriedenstab · 2023-07-24T12:20:51Z

cawemo-to-web-modeler-migration/migrate-cawemo-to-web-modeler.sh

+    NEW_PROJECT_ID=$(jq -r .id <<< "$NEW_PROJECT")
+
+    # maps folder IDs to original IDs to not create them twice + create file in right folder
+    declare -A folderIds


Does not seem to work in Zsh on macOS:

./migrate-cawemo-to-web-modeler.sh: line 77: declare: -A: invalid option declare: usage: declare [-afFirtx] [-p] [name[=value] ...]

Only happens when I run the script directly with ./migrate-cawemo-to-web-modeler.sh, not with zsh migrate-cawemo-to-web-modeler.sh 🤔.

I guess declare does not exist in sh the shell specified by the shebang at the top of the script.

To align behaviours the first line should be changed to #!/usr/bin/env zsh

Works now when using #!/bin/zsh

@jfriedenstab please verify

jfriedenstab · 2023-07-24T12:24:12Z

cawemo-to-web-modeler-migration/migrate-cawemo-to-web-modeler.sh

+                echo "⚠ POST https://modeler.cloud.camunda.io/api/beta/files failed with status code $HTTP_STATUS"
+                echo "[$(date +%s)] ⚠ POST https://modeler.cloud.camunda.io/api/beta/files failed with status code $HTTP_STATUS" >> migration.log
+            else
+                echo "\e[1A\e[K$FILE_TREE_SPACES$TREE_SYMBOL ✔ Migrated file ${GREEN}$FILE_NAME${NC} (Type: $FILE_TYPE, ID: $OLD_FILE_ID)."


The character is not displayed correctly:

\e[1A\e[K├── ✔ Migrated file New BPMN Diagram (Type: BPMN, ID: 561e690c-4424-4b9e-a483-bdbec98e8176).

Probably related to this shellcheck warning (see above):
SC2028 (info): echo may not expand escape sequences. Use printf

Only happens when I run the script directly with ./migrate-cawemo-to-web-modeler.sh, not with zsh migrate-cawemo-to-web-modeler.sh 🤔.

Works now when using #!/bin/zsh

@jfriedenstab please verify

jfriedenstab · 2023-07-24T12:25:10Z

cawemo-to-web-modeler-migration/migrate-cawemo-to-web-modeler.sh

+            OLD_FOLDER_ID=$(_folder_jq '.id')
+
+            # skip this folder if already created
+            if [ -z "${folderIds[$OLD_FOLDER_ID]}" ]


I got an error in this line:

./migrate-cawemo-to-web-modeler.sh: line 118: fc98fdfb-0e75: value too great for base (error token is "0e75")

Only happens when I run the script directly with ./migrate-cawemo-to-web-modeler.sh, not with zsh migrate-cawemo-to-web-modeler.sh 🤔.

Works now when using #!/bin/zsh

@jfriedenstab please verify

Co-authored-by: Jan Friedenstab <8794084+jfriedenstab@users.noreply.github.com>

cawemo-to-web-modeler-migration/migrate-cawemo-to-web-modeler.sh

ingorichtsmeier · 2023-07-31T12:19:53Z

$ /bin/zsh
-bash: /bin/zsh: No such file or directory

I'm out :-(

jonathanlukas · 2023-07-31T12:28:34Z

As the script requires at least bash 4 or zsh to run, should we maybe migrate it to node.js and remove system dependencies? @ingorichtsmeier

ingorichtsmeier · 2023-07-31T12:46:02Z

migrate it to node.js and remove system dependencies?

node.js is just another system dependency.

What about the system admins in the customer companies that are using Windows? Provide a PowerShell script?

Why not deliver a Spring-Boot Java application?

I haven't taken a look into this section, but what are the requirements to migrate from Cawemo to web modeler?

jonathanlukas · 2023-08-01T06:45:33Z

Node.js would be a system-agnostic runtime (just like a jre) that is quite likely to be present on a developer machine.

However, I also like the approach of a spring-boot applicationn (backend).

In the end, the script goes through projects, folders and files in cawemo and recreates the structure including files in web-modeler

We could merge this PR for now so that we have something in place and then go and see whether we migrate it to another platform (given the audience is quite small)

shaarmann · 2023-09-01T10:43:19Z

Hi,
I translated the script for Powershell and will open a pull request once the bash-script has been merged.

jonathanlukas

The script works with zsh, so all good

christian-konrad · 2023-09-04T16:48:46Z

Thank you @jonathanlukas for taking care as I wasn't able to find the time

feat: add script to migrate from Cawemo to Web Modeler

3c90589

christian-konrad linked an issue Jul 21, 2023 that may be closed by this pull request

Add script to migrate projects from Cawemo to Web Modeler #328

Closed

chore(docs): update docs for Cawemo migration script

0fc34e7

christian-konrad self-assigned this Jul 21, 2023

christian-konrad added component:cawemo-migration enhancement New feature or request labels Jul 21, 2023

jfriedenstab suggested changes Jul 24, 2023

View reviewed changes

jonathanlukas and others added 6 commits July 31, 2023 07:34

Update cawemo-to-web-modeler-migration/README.md

116a9cf

Co-authored-by: Jan Friedenstab <8794084+jfriedenstab@users.noreply.github.com>

Update cawemo-to-web-modeler-migration/README.md

a0b8b26

Co-authored-by: Jan Friedenstab <8794084+jfriedenstab@users.noreply.github.com>

Update cawemo-to-web-modeler-migration/migrate-cawemo-to-web-modeler.sh

e4782a9

Co-authored-by: Jan Friedenstab <8794084+jfriedenstab@users.noreply.github.com>

updated readme, made script executable

f8c8df3

updated log date format

6135f62

added pipefall to script

826b697

jonathanlukas requested changes Jul 31, 2023

View reviewed changes

cawemo-to-web-modeler-migration/migrate-cawemo-to-web-modeler.sh Show resolved Hide resolved

jonathanlukas changed the title ~~Add script to migrate from Cawemo to Web Modeler~~ [feature][cawemo-migration] Add script to migrate from Cawemo to Web Modeler Jul 31, 2023

jonathanlukas changed the title ~~[feature][cawemo-migration] Add script to migrate from Cawemo to Web Modeler~~ [feature][cawemo-migration]: Add script to migrate from Cawemo to Web Modeler Jul 31, 2023

use zsh

0ccd12c

jonathanlukas changed the title ~~[feature][cawemo-migration]: Add script to migrate from Cawemo to Web Modeler~~ feature:[cawemo-migration]: Add script to migrate from Cawemo to Web Modeler Aug 9, 2023

jonathanlukas changed the title ~~feature:[cawemo-migration]: Add script to migrate from Cawemo to Web Modeler~~ feat:[cawemo-migration]: Add script to migrate from Cawemo to Web Modeler Aug 9, 2023

jonathanlukas changed the title ~~feat:[cawemo-migration]: Add script to migrate from Cawemo to Web Modeler~~ feature: [cawemo-migration]: Add script to migrate from Cawemo to Web Modeler Aug 9, 2023

jonathanlukas changed the title ~~feature: [cawemo-migration]: Add script to migrate from Cawemo to Web Modeler~~ feature: [cawemo-migration] Add script to migrate from Cawemo to Web Modeler Aug 9, 2023

jonathanlukas self-requested a review September 1, 2023 11:04

jonathanlukas approved these changes Sep 1, 2023

View reviewed changes

jonathanlukas merged commit a252dcc into main Sep 1, 2023
3 checks passed

jonathanlukas deleted the 328-add-script-to-migrate-projects-from-cawemo-to-web-modeler branch September 1, 2023 11:05

shaarmann mentioned this pull request Sep 1, 2023

Add windows support to migrate from cawemo to web modeler #384

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: [cawemo-migration] Add script to migrate from Cawemo to Web Modeler #329

feature: [cawemo-migration] Add script to migrate from Cawemo to Web Modeler #329

christian-konrad commented Jul 21, 2023 •

edited

Loading

github-actions bot commented Jul 21, 2023 •

edited

Loading

jfriedenstab left a comment

jfriedenstab Jul 24, 2023

jfriedenstab Jul 24, 2023

vringar Jul 31, 2023

jonathanlukas Jul 31, 2023

jfriedenstab Jul 24, 2023

jonathanlukas Jul 31, 2023

jfriedenstab Jul 24, 2023

jonathanlukas Jul 31, 2023

ingorichtsmeier commented Jul 31, 2023

jonathanlukas commented Jul 31, 2023

ingorichtsmeier commented Jul 31, 2023

jonathanlukas commented Aug 1, 2023

shaarmann commented Sep 1, 2023

jonathanlukas left a comment

christian-konrad commented Sep 4, 2023

feature: [cawemo-migration] Add script to migrate from Cawemo to Web Modeler #329

feature: [cawemo-migration] Add script to migrate from Cawemo to Web Modeler #329

Conversation

christian-konrad commented Jul 21, 2023 • edited Loading

Add script to migrate from Cawemo to Web Modeler

Description

Testing your changes

Types of changes

Checklist:

github-actions bot commented Jul 21, 2023 • edited Loading

Test Results

jfriedenstab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ingorichtsmeier commented Jul 31, 2023

jonathanlukas commented Jul 31, 2023

ingorichtsmeier commented Jul 31, 2023

jonathanlukas commented Aug 1, 2023

shaarmann commented Sep 1, 2023

jonathanlukas left a comment

Choose a reason for hiding this comment

christian-konrad commented Sep 4, 2023

christian-konrad commented Jul 21, 2023 •

edited

Loading

github-actions bot commented Jul 21, 2023 •

edited

Loading