Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: [cawemo-migration] Add script to migrate from Cawemo to Web Modeler #329
feature: [cawemo-migration] Add script to migrate from Cawemo to Web Modeler #329
Changes from 8 commits
3c90589
0fc34e7
116a9cf
a0b8b26
e4782a9
f8c8df3
6135f62
826b697
0ccd12c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also ran
shellcheck
on the script and there are a couple of findings which might be worth fixing:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not seem to work in Zsh on macOS:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only happens when I run the script directly with
./migrate-cawemo-to-web-modeler.sh
, not withzsh migrate-cawemo-to-web-modeler.sh
🤔.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess
declare
does not exist insh
the shell specified by the shebang at the top of the script.To align behaviours the first line should be changed to
#!/usr/bin/env zsh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now when using
#!/bin/zsh
@jfriedenstab please verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got an error in this line:
Only happens when I run the script directly with
./migrate-cawemo-to-web-modeler.sh
, not withzsh migrate-cawemo-to-web-modeler.sh
🤔.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now when using
#!/bin/zsh
@jfriedenstab please verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The character is not displayed correctly:
Probably related to this shellcheck warning (see above):
SC2028 (info): echo may not expand escape sequences. Use printf
Only happens when I run the script directly with
./migrate-cawemo-to-web-modeler.sh
, not withzsh migrate-cawemo-to-web-modeler.sh
🤔.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now when using
#!/bin/zsh
@jfriedenstab please verify