Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows support to migrate from cawemo to web modeler #384

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Add windows support to migrate from cawemo to web modeler #384

merged 3 commits into from
Oct 26, 2023

Conversation

shaarmann
Copy link
Collaborator

@shaarmann shaarmann commented Sep 1, 2023 •
edited
Loading

Camunda Community Hub Pull Request Template

Description

Adds a Powershell script to perform the Cawemo to Webmodeler migration on Windows clients.

Additional context

Compare #329

Testing your changes

  • Manual testing against Cawemo and Web Modeler SaaS
  • There is no API for Cawemo to create new files, hence automated tests can't be written

Types of changes

  • Bug fix (non-breaking change which fixes an existing open issue)
  • New feature (non-breaking change which adds functionality to an extension)
  • Breaking change (fix or feature that would cause existing functionality of an extension to change)
  • Documentation update (changes made to an existing piece of documentation)

Checklist:

  • My code adheres to the syntax used by this extension.
  • My pull request requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the Camunda Community Hub documentation.
  • I have read the Pull Request Process documentation.
  • I have added or suggested tests to cover my changes suggested in this pull request.
  • All new and existing CI/CD tests passed.
  • I will /assign myself this issue, and add the relevant [issue labels] to it if they are not automatically generated by Probot.
  • I will tag @camunda-community-hub/devrel in a new comment on this issue if 30 days have passed since my pull request was opened and I have not received a response from the extension's maintainer.

@shaarmann shaarmann self-assigned this Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023 •
edited
Loading

Test Results

  25 files  +  25    25 suites  +25   1m 55s ⏱️ + 1m 55s
219 tests +219  219 ✔️ +219  0 💤 ±0  0 ❌ ±0 
335 runs  +335  335 ✔️ +335  0 💤 ±0  0 ❌ ±0 

Results for commit df2f15e. ± Comparison against base commit a252dcc.

♻️ This comment has been updated with latest results.

@shaarmann
Copy link
Collaborator Author

Hi @ingorichtsmeier,
as a fellow Windows user, do you mind reviewing this pull request at your convenience?

@shaarmann
Reduce number of 400 for DMNs
df2f15e 
- These changes add support for DMNs that *do not contain*
  - DRD elements with an empty label
  - Literal expressions
@jonathanlukas jonathanlukas merged commit 2380abf into main Oct 26, 2023
5 checks passed
@jonathanlukas jonathanlukas deleted the add-windows-support-to-migrate-from-cawemo-to-web-modeler branch November 3, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingorichtsmeier ingorichtsmeier Awaiting requested review from ingorichtsmeier

Assignees

@shaarmann shaarmann

Labels
component:cawemo-migration enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaarmann @jonathanlukas