-
Notifications
You must be signed in to change notification settings - Fork 46
[backlog table] Update as of 19/03 #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backlog table] Update as of 19/03 #187
Conversation
What type of PR is this? documentation subproject management Summary: Update Facial Recognition & Energy Footprint Notification as TSC approved Include new backlog entries for: Voice Notification Voice Verification Code Dynamic Connectivity Data
caubut-charter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the submission. A few items before merging:
- It looks like you may need to merge main into your branch as this PR reverts some previously fixed entries.
- Some of the formatting on the tags aren't aligned with the rest of the document.
- The basic shape of a row is also a little different from the rest of the document. For instance, the Maintainer links aren't wrapped in divs.
I only commented directly on a few occurrences, but it looks like most additions will need to be adjusted.
eSIM API has been modified and now sent to TSC
Merge Maintainers into this branch and carefully just choose your own updates you made from your branch. Other entries don't wrap Maintainers in a div and the indentation needs some tweaking Co-authored-by: Christopher Aubut <89488056+caubut-charter@users.noreply.github.com>
…eviceManagement, ConsentInfo, and fix some dates
…ewed the submission and requested changes before approval. This helps distinguish between proposals under discussion and those that need updates based on TSC feedback
|
Please merge this PR as soon as possible (I would recommend to have only short-running PRs for these updates, to avoid that the PR is already outdated when it gets reviews). We have the release information already:
With that the added value of concrete release information within the APIBacklog table might be limited. |
Hi @hdamker, I totally agree, we should merge this PR as soon as possible. What you propose to reflect the spring25 or reduce the information in the last column I don't have a strong opinion about that because although the information is accessible in many places, not everyone accesses by the same ways depending on the role they have in the organization, so I don't see bad to have it here either, but we can scale it as an Action Point in the next TSC (@jgarciahospital) Continuing with the point of merge this PR, all the requested changes are already committed, but I don't have permissions to merge it, if you could approve the code and close this issue. |
My approval wouldn't unblock the PR as I'm not a codeowner here, you need one codeowner review and approval. Best would be if @caubut-charter confirms with an approval that his requested changes are done, otherwise you would need to dismiss this review before you can merge. |
jgarciahospital
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
caubut-charter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small formatting changes.
caubut-charter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more. Will do a quick visual test as it looks like some rows have a different number of columns at a glance.
caubut-charter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more from visual inspection.
caubut-charter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@caubut-charter the changes are looking good, but it's actually a loop-hole that you are able to approve and merge as a co-author and after making the last changes (YOLO ... you love it you merge it 😉). |
|
@hdamker I was wondering why I was allowed. I know GitLab has a setting to disable approving if you add commits, not sure about GitHub. |
What type of PR is this?
Summary:
What this PR does / why we need it:
Including status changes on #24, #167, #73, #95, #30, #67, #164, #144, #128, #127, #35