feat: update recording, transcript endpoint and add tests #25771
Merged
feat: update recording, transcript endpoint and add tests #25771
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
apps/api/v2/src/ee/bookings/2024-08-13/controllers/bookings.controller.ts
Show resolved
Hide resolved
Contributor
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
hariombalhara
approved these changes
Jan 6, 2026
volnei
reviewed
Jan 13, 2026
Contributor
volnei
left a comment
volnei
left a comment
There was a problem hiding this comment.
hey @Udit-takkar any risk or breaking changes on those comments?
apps/api/v2/src/ee/bookings/2024-08-13/controllers/bookings.controller.ts
Show resolved
Hide resolved
apps/api/v2/src/ee/bookings/2024-08-13/controllers/bookings.controller.ts
Show resolved
Hide resolved
Contributor
E2E results are ready! |
volnei
approved these changes
Jan 13, 2026
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Summary by cubic
Protect booking recordings and transcripts endpoints with PBAC and auth guards, and add E2E tests to verify access control. Clean up response payloads by removing the temporary message field.
Written for commit 16f2532. Summary will update on new commits.