Skip to content

[CLEAN] Synthetic Benchmark PR #25771 - feat: update recording, transcript endpoint and add tests #691

Closed
tomerqodo wants to merge 1 commit intobase_pr_25771_20260121_8592from
clean_pr_25771_20260121_8592
Closed

[CLEAN] Synthetic Benchmark PR #25771 - feat: update recording, transcript endpoint and add tests #691
tomerqodo wants to merge 1 commit intobase_pr_25771_20260121_8592from
clean_pr_25771_20260121_8592

Conversation

@tomerqodo
Copy link

Benchmark PR calcom#25771

Type: Clean (correct implementation)

Original PR Title: feat: update recording, transcript endpoint and add tests
Original PR Description: ## What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?


Summary by cubic

Protect booking recordings and transcripts endpoints with PBAC and auth guards, and add E2E tests to verify access control. Clean up response payloads by removing the temporary message field.

  • Refactors
    • Guarded GET /v2/bookings/:bookingUid/recordings and /transcripts with ApiAuthGuard, BookingUidGuard, and BookingPbacGuard.
    • Removed message from GetBookingRecordingsOutput and GetBookingTranscriptsOutput.
    • Added E2E tests for organizer (200) and unauthorized user (403).

Written for commit 16f2532. Summary will update on new commits.

Original PR URL: calcom#25771

@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CLEAN] Synthetic Benchmark PR #25771 - feat: update recording, transcript endpoint and add tests ". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions
Copy link

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions bot added the Stale label Jan 30, 2026
@github-actions
Copy link

This PR has been closed due to inactivity. Please feel free to reopen it if you'd like to continue the work.

@github-actions github-actions bot closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant