Skip to content

Code Review Bench PR #25771 - feat: update recording, transcript endpoint and add tests #16

Open
tomerqodo wants to merge 2 commits intobase_pr_25771_20260125_1225from
corrupted_pr_25771_20260125_1225
Open

Code Review Bench PR #25771 - feat: update recording, transcript endpoint and add tests #16
tomerqodo wants to merge 2 commits intobase_pr_25771_20260125_1225from
corrupted_pr_25771_20260125_1225

Conversation

@tomerqodo
Copy link

Code Review Bench PR calcom#25771

Original PR Title: feat: update recording, transcript endpoint and add tests
Original PR Description: ## What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?


Summary by cubic

Protect booking recordings and transcripts endpoints with PBAC and auth guards, and add E2E tests to verify access control. Clean up response payloads by removing the temporary message field.

  • Refactors
    • Guarded GET /v2/bookings/:bookingUid/recordings and /transcripts with ApiAuthGuard, BookingUidGuard, and BookingPbacGuard.
    • Removed message from GetBookingRecordingsOutput and GetBookingTranscriptsOutput.
    • Added E2E tests for organizer (200) and unauthorized user (403).

Written for commit 16f2532. Summary will update on new commits.

Original PR URL: calcom#25771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant