a11y: Make search field accessible for screen reader #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

PaStucky wants to merge 103 commits into develop from feature/AUDIT-7-make-search-accessible

PaStucky commented Jul 3, 2025 •

edited

Loading

Improve accessibility of the search dialog.

Status before change

When search dialog is open, the first search result is read by the screen reader
There is no way of making the screen reader read out the search input field

Goal of this task

Improve readability of the search dialog

Changes

When the first search result is selected and the user presses key up, the screen reader reads out the search input field
Navigation the results is not changed for all other cases

PaStucky and others added 4 commits

July 3, 2025 09:33


          feat: Make search field accessbile with arrows

4017ca6


          Update the mobile_guide page to the new design and link out to Elemen…

90f4d34

…t X by default. (element-hq#30172)

* Reapply "Update the mobile_guide page to the new design. (element-hq#30006)" (element-hq#30104)

This reverts commit c51823d.

* Use Element X as the default mobile_guide_app_variant when omitted.

* Fix a build error on Windows.

Additionally revert "Remove unnecessary <%= require %> usages" and let webpack handle all of the assets (without a manual copy rule).

* Exclude mobile_guide from coverage gate

It has playwright tests

* Revert the re-introduction of <%= require %>

* Fix snapshot tests on mobile_guide.

---------

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>


          feat: Adapted code comment

7d1bbfd


          Fix release announcement test flake (element-hq#30250)

66d7c6a

* chore: add `hideJumpToBottomButton` option to playwright screenshot

* test: hide jump to bottom button in release announcement test

PaStucky requested a review from dreypka

July 3, 2025 11:06

uhoreg and others added 25 commits

July 3, 2025 13:34


          Avoid using accessSecretStorage to create 4S (element-hq#30244)

9095ebd

* remove resetCrossSigning flag, which is no longer in use

* drop unnecessary check for cross-signing

The only place where verifyUser is called already checks that cross-signing is
set up.  (The function name is also incorrect, since it checks for the
cross-signing key, and not for 4S.)

* avoid calling accessSecretStorage to set up cross-signing or 4S

Send the user to the Encryption settings tab instead

* only create secret storage when specifically asked to

* deprecate using accessSecretStorage to create new 4S

* also remove the obsolete snapshot

* add tests

* Tweak comment

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

---------

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>


          Rename the mobile_guide_app_variant config values to be clearer. (ele…

5dd3168

…ment-hq#30258)

* Fix the default mobile_guide links.

Whilst the script should update these if it fails these should link to Element X which is now the default app that we link out to from this page.

* Rename the mobile_guide_app_variant values to be clearer.

Also handle invalid config values by defaulting to Element X.

* Rename snapshots to match new app variant identifiers.


          Fix e2e flakes in new room list (element-hq#30254)

1cb068a

* test: retry failing assertion in room list

* test: fix click on room not visible after scroll


          Add support for module message hint allowDownloadingMedia (element-…

9f313fc

…hq#30252)

* Add support for allowDownloadingMedia

* Add tests.

* Allow downloading when no event is associated.

* fix lint

* Update module API

* Update lock file too

* force CI


          [create-pull-request] automated change (element-hq#30218)

0f7e394

Co-authored-by: t3chguy <2403652+t3chguy@users.noreply.github.com>


          Fix transparent verification checkmark in dark mode (element-hq#30235)

aa2dc8e

* Fix transparent verification checkmark in dark mode

Fixes Issue element-hq#28285

* Add white background to E2E Warning Icon

Also adapted the testcases to the new background.


          [create-pull-request] automated change (element-hq#30269)

df50a50

Co-authored-by: t3chguy <2403652+t3chguy@users.noreply.github.com>


          Upgrade dependency to matrix-js-sdk@37.11.0-rc.0

33f3ee1


          v1.11.106-rc.0

3a01a00


          Update Node.js to 125996c (element-hq#30274)

fd45eaa

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency @vector-im/compound-design-tokens to v4.0.5 (elemen…

39dcaaa

…t-hq#30278)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency @sentry/browser to v9.35.0 (element-hq#30283)

09cea4a

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency @stylistic/eslint-plugin to v5 (element-hq#30285)

14d1141

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency postcss-mixins to v12 (element-hq#30289)

a75c5e2

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency dotenv to v17 (element-hq#30288)

c1f2913

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update playwright to v1.53.2 (element-hq#30279)

8c7daae

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update definitelyTyped (element-hq#30277)

02f7c9b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update nginxinc/nginx-unprivileged:alpine-slim Docker digest to ef010…

a1db6f5

…0e (element-hq#30273)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency cronstrue to v3 (element-hq#30287)

6ce5228

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update typescript-eslint monorepo to v8.35.1 (element-hq#30280)

afb8e38

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update babel monorepo to v7.28.0 (element-hq#30282)

f6e8350

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          [create-pull-request] automated change (element-hq#30294)

31e6f15

Co-authored-by: t3chguy <2403652+t3chguy@users.noreply.github.com>


          Update dependency @vector-im/compound-design-tokens to v5 (element-hq…

6fbc2e7

…#30286)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency testcontainers to v11.1.0 (element-hq#30284)

cfd3a96

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          [create-pull-request] automated change (element-hq#30219)

287a064

Co-authored-by: t3chguy <2403652+t3chguy@users.noreply.github.com>

renovate bot and others added 30 commits

July 22, 2025 16:13


          Update dependency @stylistic/eslint-plugin to v5.2.0 (element-hq#30376)

b35e2a8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update Node.js to a803244 (element-hq#30370)

16ab7ff

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Move Flex & Box component into shared component folder (element-hq#30357

1e689ac

)

* refactor: move Flex component in shared components

* refactor: update imports

* refactor: remove Flex pcss file

* fix: Flex component css override

* test: update snapshots

* fix: html export

* chore: add css module support to jest

* chore: keep old copyright

* refactor: change `mx_Flex` in `ErrorView` to `mx_ErrorView_flexContainer`

* test: update snapshots

* refactor: move Box component in shared components

* refactor: update import and css override

* test: update snapshots


          Update dependency testcontainers to v11.3.0 (element-hq#30377)

4c1e3c8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update playwright to v1.54.1 (element-hq#30378)

354867b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency @types/node to v18.19.120 (element-hq#30371)

0dc7fcc

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update all non-major dependencies (element-hq#30374)

62b080a

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency @sentry/webpack-plugin to v4 (element-hq#30381)

6a48183

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update typescript-eslint monorepo to v8.37.0 (element-hq#30379)

4ec10a9

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          [create-pull-request] automated change (element-hq#30326)

941835c

Co-authored-by: t3chguy <2403652+t3chguy@users.noreply.github.com>


          [create-pull-request] automated change (element-hq#30384)

6b40da5

Co-authored-by: t3chguy <2403652+t3chguy@users.noreply.github.com>


          Script for updating storybook screenshots (element-hq#30340)

dcbba5e

* Script for updating storybook screenshots

Requires element-hq/element-modules#43

* Prettier


          Change color of public room icon (element-hq#30390)

7bfb981

* feat: change color of public room icon

* test: update room avatar snapshot

* test(e2E): update screenshots


          Storybook: add tooltip provider and sort stories (element-hq#30392)

16ef503

* chore: add tooltip provider to storybook preview

* chore: order story alphabetically


          [create-pull-request] automated change (element-hq#30394)

ba828b2

Co-authored-by: t3chguy <2403652+t3chguy@users.noreply.github.com>


          Update playwright-common package (element-hq#30396)

f7ef948

So the shared components screenshot generator works


          Allow for unknown event shield reasons (element-hq#30397)

ffedca3

A forthcoming change to the js-sdk will add a new event shield reason. To avoid
a compile-time failure, add a `default` case to the code handling those
reasons.


          Change unencrypted and public pills to blue (element-hq#30399)

ab26004

* feat: change unencrypted and public pill to blue

* test: update snapshots

* test(e2e): update screenshots


          fix: replace hardcoded string on qr code back button (element-hq#30401)

81edfec


          fix: replace hardcoded string in poll history dialog (element-hq#30402)

3af8273


          chore: move i18n.tsx into utils folder (element-hq#30400)

b5160c4


          Support EventShieldReason.MISMATCHED_SENDER (element-hq#30403)

fc04ad2

The js-sdk now exposes a new event shield reason, which we should handle
correctly.


          Work around jest bug that swallows console output (element-hq#30405)

d384a9b

* Work around jest bug that swallows console output

Hacky workaround for jestjs/jest#15747

* Fix unit test

* Only write logs if there are some to write

* Another test fix


          Fix e2e shield being invisible in white mode for encrypted room (elem…

c98358c

…ent-hq#30408)

* fix: e2e icon for encrypted room

* test(e2e): add screenshot for grey shield in encrypted room


          Lifecycle: add a bit more logging (element-hq#30414)

c2c040d

... to see what exactly it thinks is wrong with the session

This may be useful in debugging
element-hq#30337 and
element-hq#29708. but will likely be
useful in any case.


          Allow Element Call to send call notifications (element-hq#30404)

a23a2c0

* Allow Element Call to send call notifications

Currently Element Web is responsible for sending the call notification event, but this is planned to be changed soon. As of the upcoming Element Call 0.14.0 release, it will request the capability to send call notifications itself, and we should auto-approve this capability.

* Add reaction capability missing from test

Element Call does in fact request this one.


          bump wysiwyg to 2.39.0 (element-hq#30421)

beaabd5


          MatrixChat test robustness fixes (element-hq#30413)

7e40e36

* MatrixChat-test: clean up better in `afterEach`

Make the MatrixChat tests behave better by letting them finish their work in an
`act` in afterEach. Otherwise we can end up mounting new components during
cleanup, which run tasks in the background

* MatrixChat-test: clean up dispatcher test

This test was kicking off a dispatcher job which would then open a
UserDeviceSettings dialog once the test had finished. That would then throw
exceptions because some of the mock environment had been torn down.

We're just testing that it opens the right dialog, so better to intercept
`createDialog`.

Aso add an `act` to reduce warnings, and replace a `flushPromises` with a
`waitFor` to make the test more robust.


          Re-enable matrixchat test (element-hq#30410)

45a2fd9

Now that we have better logging for our tests
(element-hq#30405), I'd like to re-enable
this test so we can try and understsnd what makes it fail.


          Merge branch 'develop' into feature/AUDIT-7-make-search-accessible

81acdd2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet