Revert "Update the mobile_guide page to the new design." #30104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e74871.
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Jun 22, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2025
…t X by default. (#30172) * Reapply "Update the mobile_guide page to the new design. (#30006)" (#30104) This reverts commit c51823d. * Use Element X as the default mobile_guide_app_variant when omitted. * Fix a build error on Windows. Additionally revert "Remove unnecessary <%= require %> usages" and let webpack handle all of the assets (without a manual copy rule). * Exclude mobile_guide from coverage gate It has playwright tests * Revert the re-introduction of <%= require %> * Fix snapshot tests on mobile_guide. --------- Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
…t X by default. (element-hq#30172) * Reapply "Update the mobile_guide page to the new design. (element-hq#30006)" (element-hq#30104) This reverts commit c51823d. * Use Element X as the default mobile_guide_app_variant when omitted. * Fix a build error on Windows. Additionally revert "Remove unnecessary <%= require %> usages" and let webpack handle all of the assets (without a manual copy rule). * Exclude mobile_guide from coverage gate It has playwright tests * Revert the re-introduction of <%= require %> * Fix snapshot tests on mobile_guide. --------- Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30006 due to breaking Windows compatibility https://github.com/element-hq/element-web/actions/runs/15559495760/job/43808032961