MatrixChat test robustness fixes #30413
Merged
+24
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the MatrixChat tests behave better by letting them finish their work in an `act` in afterEach. Otherwise we can end up mounting new components during cleanup, which run tasks in the background
This test was kicking off a dispatcher job which would then open a UserDeviceSettings dialog once the test had finished. That would then throw exceptions because some of the mock environment had been torn down. We're just testing that it opens the right dialog, so better to intercept `createDialog`. Aso add an `act` to reduce warnings, and replace a `flushPromises` with a `waitFor` to make the test more robust.
richvdh
force-pushed
the
rav/matrixchat_test_fixes
branch
from
746cbb4 to
ea71074
Compare
t3chguy
approved these changes
Jul 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
* MatrixChat-test: clean up better in `afterEach` Make the MatrixChat tests behave better by letting them finish their work in an `act` in afterEach. Otherwise we can end up mounting new components during cleanup, which run tasks in the background * MatrixChat-test: clean up dispatcher test This test was kicking off a dispatcher job which would then open a UserDeviceSettings dialog once the test had finished. That would then throw exceptions because some of the mock environment had been torn down. We're just testing that it opens the right dialog, so better to intercept `createDialog`. Aso add an `act` to reduce warnings, and replace a `flushPromises` with a `waitFor` to make the test more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a couple of cleanups in MatrixChat which may make it more robust, but at the very least will make it log less spam.
Possible this will help with #30337 and/or #29708