fix(buildParams): use brackets for arrays #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 93 93
Lines 471 473 +2
Branches 19 20 +1
=========================================
+ Hits 471 473 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fix(subscription/user/status): set correct return type
Deploying with
|
| Latest commit: |
79406c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07f234da.braze-api.pages.dev |
| Branch Preview URL: | https://ww-global-params-array.braze-api.pages.dev |
remarkablemark
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Fix a bug where passing multiple users to the user subscription lookup endpoint requires
[]around the keyshttps://www.braze.com/docs/api/endpoints/subscription_groups/get_list_user_subscription_groups/?tab=multiple%20users
This will replace #328 if we like this style better. I do, but it's only if Braze is consistent with this.
What is the current behavior?
/subscription/user/status?external_id=1&external_id=2What is the new behavior?
/subscription/user/status?external_id[]=1&external_id=2Checklist: