Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscription/user/status): set correct return type #330

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

wweaver
Copy link
Collaborator

@wweaver wweaver commented Aug 2, 2023

What is the motivation for this pull request?

Bug fix for the return type of user subscriptions

What is the current behavior?

Returns only

{ 
    message: string
    errors?: string[]
}

What is the new behavior?

Returns

{
  users: Array<{
    email: string | null
    phone: string | null
    external_id: string | null
    subscription_groups: Array<{
      id: string
      name: string
      channel: string
      status: 'Subscribed' | 'Unsubscribed'
    }>
  }>
  total_count: number
  message: string
  errors?: string[]
}

User_s_Subscriptions_-_My_Workspace

Checklist:

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #330 (21a88d6) into ww/global-params-array (f66d284) will not change coverage.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##           ww/global-params-array      #330   +/-   ##
========================================================
  Coverage                  100.00%   100.00%           
========================================================
  Files                          93        93           
  Lines                         473       473           
  Branches                       20        20           
========================================================
  Hits                          473       473           
Files Changed Coverage Δ
src/subscription/user/status.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@remarkablemark remarkablemark added the bug Something isn't working label Aug 2, 2023
@remarkablemark remarkablemark merged commit 79406c4 into ww/global-params-array Aug 2, 2023
7 checks passed
@remarkablemark remarkablemark deleted the ww/subscription-user-status branch August 2, 2023 20:14
@remarkablemark
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants