Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user-subscriptions): pass brackets for array syntax #328

Closed
wants to merge 1 commit into from

Conversation

wweaver
Copy link
Collaborator

@wweaver wweaver commented Aug 2, 2023

What is the motivation for this pull request?

Fix a bug where passing multiple users to the user subscription lookup endpoint requires [] around the keys

https://www.braze.com/docs/api/endpoints/subscription_groups/get_list_user_subscription_groups/?tab=multiple%20users

image

What is the current behavior?

/subscription/user/status?external_id=1&external_id=2

What is the new behavior?

/subscription/user/status?external_id[]=1&external_id=2

Checklist:

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 34c64b0
Status: ✅  Deploy successful!
Preview URL: https://dbc594af.braze-api.pages.dev
Branch Preview URL: https://status-get.braze-api.pages.dev

View logs

@wweaver wweaver changed the title fix(user-subscriptions): Pass brackets for array syntax fix(user-subscriptions): pass brackets for array syntax Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #328 (34c64b0) into master (5c47b70) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #328   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines          471       479    +8     
  Branches        19        25    +6     
=========================================
+ Hits           471       479    +8     
Files Changed Coverage Δ
src/subscription/status/get.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wweaver
Copy link
Collaborator Author

wweaver commented Aug 2, 2023

@remarkablemark not sure if you know if this kind of change can be made globally in the buildParams function. If so I can push this up into that to make it global change.

@wweaver wweaver closed this Aug 2, 2023
@wweaver wweaver deleted the status-get branch August 2, 2023 19:37
@remarkablemark
Copy link
Member

Global in buildParam works for me @wweaver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants