Merged
Conversation
This reverts commit bd0b93e.
These are broken when cross-compiling for x86_64 on arm64.
The following test currently fails: 16:34:58 perl ./scripts/maint/checkSpace.pl -C \ 16:34:58 ./src/lib/*/*.[ch] ./src/core/*/*.[ch] ./src/feature/*/*.[ch] ./src/app/*/*.[ch] ./src/test/*.[ch] ./src/test/*/*.[ch] ./src/tools/*.[ch] 16:34:58 /opt/homebrew/bin/python3 ./scripts/maint/practracker/includes.py . 16:34:58 ./scripts/maint/checkShellScripts.sh 16:34:58 Unusual pattern permitted.h in ./scripts/maint/practracker/testdata 16:34:58 ./scripts/maint/checkShellScripts.sh: Install shellcheck to check shell scripts. ... 16:35:05 FAIL: scripts/maint/practracker/test_practracker.sh These tests are already disabled on arm64-apple-darwin (#158).
This was referenced Jan 29, 2026
Contributor
|
Can this pr solve FAIL: scripts/maint/practracker/test_practracker.sh? |
Member
Author
|
@waybackarchiver Yes, the tor tests will not be run on Mac anymore. |
diracdeltas
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #164 which disabled the zlib tests for the wrong architecture, and disable the tor tests entirely on Mac.