Skip to content

Disable zlib tests on x86_64-apple-darwin#164

Merged
fmarier merged 1 commit intomasterfrom
disable-zlib-tests-macos
Jan 29, 2026
Merged

Disable zlib tests on x86_64-apple-darwin#164
fmarier merged 1 commit intomasterfrom
disable-zlib-tests-macos

Conversation

@fmarier
Copy link
Copy Markdown
Member

@fmarier fmarier commented Jan 29, 2026

These are broken when cross-compiling for x86_64 on arm64:

12:03:26  gcc -dynamiclib -install_name /Users/jenkins/jenkins/workspace/brave-tor-client-build-macos/x86_64/zlib-1.3.1/root/lib/libz.1.dylib -compatibility_version 1 -current_version 1.3.1 -target x86_64-apple-macos11 -fPIC -DHAVE_HIDDEN -o libz.1.3.1.dylib adler32.lo crc32.lo deflate.lo infback.lo inffast.lo inflate.lo inftrees.lo trees.lo zutil.lo compress.lo uncompr.lo gzclose.lo gzlib.lo gzread.lo gzwrite.lo  -lc -target x86_64-apple-macos11

2:03:26 
 /bin/sh: ./minigzip: Bad CPU type in executable
12:03:26 
 /bin/sh: ./minigzip: Bad CPU type in executable
12:03:26  		*** zlib test FAILED ***
12:03:26 
 make: *** [teststatic] Error 1
12:03:26  make: *** Waiting for unfinished jobs....
12:03:26  /bin/sh: ./minigzipsh: Bad CPU type in executable
12:03:26  /bin/sh: ./minigzipsh: Bad CPU type in executable
12:03:26  		*** zlib shared test FAILED ***
12:03:26  make: *** [testshared] Error 1

@fmarier fmarier requested a review from diracdeltas January 29, 2026 00:21
@fmarier fmarier self-assigned this Jan 29, 2026
These are broken when cross-compiling for x86_64 on arm64.
@fmarier fmarier force-pushed the disable-zlib-tests-macos branch from 6ca284c to 33b6b45 Compare January 29, 2026 00:22
@fmarier fmarier changed the title Disable zlib tests on macOS Disable zlib tests on x86_64-apple-darwin Jan 29, 2026
@fmarier
Copy link
Copy Markdown
Member Author

fmarier commented Jan 29, 2026

The x86_64 build is still broken, but for other reasons. The zlib tests are correctly ignored and so I'll merge.

@fmarier fmarier merged commit bd0b93e into master Jan 29, 2026
4 of 5 checks passed
@fmarier fmarier deleted the disable-zlib-tests-macos branch January 29, 2026 18:43
@fmarier fmarier mentioned this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants