Merged
Conversation
FAIL: src/test/unittest_part8.sh util/monotonic_time_add_msec: FAIL src/test/test_util.c:6644: assert(monotime_coarse_diff_msec32_(&ct1, &ct2) OP_GT 1323): 1310 vs 1323 [monotonic_time_add_msec FAILED] Filed #155 to re-enable later.
mihaiplesa
previously approved these changes
Oct 2, 2025
FAILED regress_debug: OKAY regress_debug: http/data_length_constraints: FAIL test/regress_http.c:1343: assert(!req) [data_length_constraints FAILED] OKAY 1/296 TESTS FAILED. (41 skipped) FAILED Filed #156 to re-enable later.
fmarier
force-pushed
the
mac-x86_64-builds
branch
from
1673bba to
9f7b30b
Compare
Closed
mihaiplesa
approved these changes
Oct 2, 2025
fmarier
added a commit
that referenced
this pull request
Jan 29, 2026
The following test currently fails: 16:34:58 perl ./scripts/maint/checkSpace.pl -C \ 16:34:58 ./src/lib/*/*.[ch] ./src/core/*/*.[ch] ./src/feature/*/*.[ch] ./src/app/*/*.[ch] ./src/test/*.[ch] ./src/test/*/*.[ch] ./src/tools/*.[ch] 16:34:58 /opt/homebrew/bin/python3 ./scripts/maint/practracker/includes.py . 16:34:58 ./scripts/maint/checkShellScripts.sh 16:34:58 Unusual pattern permitted.h in ./scripts/maint/practracker/testdata 16:34:58 ./scripts/maint/checkShellScripts.sh: Install shellcheck to check shell scripts. ... 16:35:05 FAIL: scripts/maint/practracker/test_practracker.sh These tests are already disabled on arm64-apple-darwin (#158).
fmarier
added a commit
that referenced
this pull request
Feb 4, 2026
The following test currently fails: 16:34:58 perl ./scripts/maint/checkSpace.pl -C \ 16:34:58 ./src/lib/*/*.[ch] ./src/core/*/*.[ch] ./src/feature/*/*.[ch] ./src/app/*/*.[ch] ./src/test/*.[ch] ./src/test/*/*.[ch] ./src/tools/*.[ch] 16:34:58 /opt/homebrew/bin/python3 ./scripts/maint/practracker/includes.py . 16:34:58 ./scripts/maint/checkShellScripts.sh 16:34:58 Unusual pattern permitted.h in ./scripts/maint/practracker/testdata 16:34:58 ./scripts/maint/checkShellScripts.sh: Install shellcheck to check shell scripts. ... 16:35:05 FAIL: scripts/maint/practracker/test_practracker.sh These tests are already disabled on arm64-apple-darwin (#158).
waybackarchiver
pushed a commit
to tor-actions/tor-build-scripts
that referenced
this pull request
Feb 6, 2026
* Revert "Disable zlib tests on macOS" This reverts commit bd0b93e. * Disable zlib tests on x86_64-apple-darwin These are broken when cross-compiling for x86_64 on arm64. * Disable tor tests on x86_64-apple-darwin The following test currently fails: 16:34:58 perl ./scripts/maint/checkSpace.pl -C \ 16:34:58 ./src/lib/*/*.[ch] ./src/core/*/*.[ch] ./src/feature/*/*.[ch] ./src/app/*/*.[ch] ./src/test/*.[ch] ./src/test/*/*.[ch] ./src/tools/*.[ch] 16:34:58 /opt/homebrew/bin/python3 ./scripts/maint/practracker/includes.py . 16:34:58 ./scripts/maint/checkShellScripts.sh 16:34:58 Unusual pattern permitted.h in ./scripts/maint/practracker/testdata 16:34:58 ./scripts/maint/checkShellScripts.sh: Install shellcheck to check shell scripts. ... 16:35:05 FAIL: scripts/maint/practracker/test_practracker.sh These tests are already disabled on arm64-apple-darwin (brave#158). * tor update --------- Co-authored-by: Francois Marier <francois@brave.com> Co-authored-by: brave-builds <brave-builds+devops@brave.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR harmonizes the way that both arm64 and x86_64 binaries are built and explicitly sets the compilation CPU and HOST so that they can be built on either architecture.
The individual commits are probably easier to review due to the indentation fixes.