containerd-2.1: add configurable concurrent-download-chunk-size setting#645
containerd-2.1: add configurable concurrent-download-chunk-size setting#645KCSesh merged 2 commits intobottlerocket-os:developfrom
Conversation
|
Thanks for the PR @KCSesh ! Just a quick question: From the original PR in containerd, it seems there are 2 other settings that can be configured to help improve image pull performance.
Are these already configurable via BottleRocket or can we add support for these as well in this PR? |
|
Hey @vrdn-23, thanks for taking a look and the interest! 😄 You are correct that at one point, the PR introduced 2 additional knobs ( However, later on in the PR through discussion, the 2 additional values was reduced to 1 value here with the specific commit here. The merged result only added The 3rd variable: |
|
That makes sense! Thanks for the explanation @KCSesh. Looking forward to testing this out! |
Signed-off-by: Kyle Sessions <kssessio@amazon.com>
b83cc68 to
c393c27
Compare
packages/containerd-2.1/containerd-config-toml_k8s_containerd_sock
Outdated
Show resolved
Hide resolved
Signed-off-by: Kyle Sessions <kssessio@amazon.com>
c393c27 to
977dbf4
Compare
|
^ Making use of the default instead of if/else |
Description of changes:
Add
concurrent-download-chunk-sizesetting in the containerd-2.1 config.toml, allowing for transfer service default to be updated.Related:
Testing done:
Set several chunk_sizes and verfied they updated the config properly.
Also verified via debug, containerd logs during image fetch:
Details
concurrent-layer-fetch-bufferconfig.toml:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.