kubernetes: add pid resource to kubeReserved setting#646
Merged
koooosh merged 2 commits intobottlerocket-os:developfrom Sep 30, 2025
Merged
kubernetes: add pid resource to kubeReserved setting#646koooosh merged 2 commits intobottlerocket-os:developfrom
koooosh merged 2 commits intobottlerocket-os:developfrom
Conversation
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
Signed-off-by: Kush Upadhyay <kushupad@amazon.com>
koooosh
force-pushed
the
test-reserve-compute-setting
branch
from
ef7deda to
66495d1
Compare
vigh-m
approved these changes
Sep 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
bottlerocket-os/bottlerocket#3788
Description of changes:
Adds a
pidfield to thekubeReservedsetting for all existing kubelet configs (1.28 - 1.34). As mentioned in thebottlerocket-settings-sdkPR, this feature was marked stable in k8s-1.20.The
systemReservedsetting doesn't need to be updated since it simply loops through the keys.Related to:
The new setting in the PR above was released in
bottlerocket-settings-models-v0.16.0, so bumping the respective sources in the core-kit to take that change.Testing done:
See Testing Description section here: bottlerocket-os/bottlerocket-settings-sdk#98
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.