Add migration for concurrent-download-chunk-size in container-runtime #4638
Merged
KCSesh merged 3 commits intobottlerocket-os:developfrom Sep 9, 2025
Merged
Add migration for concurrent-download-chunk-size in container-runtime #4638KCSesh merged 3 commits intobottlerocket-os:developfrom
KCSesh merged 3 commits intobottlerocket-os:developfrom
Conversation
5f9b150 to
4b33546
Compare
ytsssun
approved these changes
Sep 9, 2025
piyush-jena
reviewed
Sep 9, 2025
sources/settings-migrations/v1.47.0/container-runtime-concurrent-download-chunk-size/Cargo.toml
Outdated
Show resolved
Hide resolved
koooosh
approved these changes
Sep 9, 2025
Contributor
koooosh
left a comment
There was a problem hiding this comment.
LGTM, aside from removing the maplit.workspace = true dependency
4b33546 to
b04b2db
Compare
piyush-jena
approved these changes
Sep 9, 2025
Signed-off-by: Kyle Sessions <kssessio@amazon.com>
Signed-off-by: Kyle Sessions <kssessio@amazon.com>
Signed-off-by: Kyle Sessions <kssessio@amazon.com>
b04b2db to
a54533f
Compare
piyush-jena
approved these changes
Sep 9, 2025
koooosh
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
concurrent-download-chunk-sizewhich only works incontainerd-2.1Testing done:
Re-ran migration with released core-kit.
Tested migration:
1.46.0 -> 1.47.0 -> 1.46.0on a custom eks-1.33 with containerd-2.1, and on aws-eks-1.32 (where the setting is a no-op)1.46.0:
moved to 1.47.0:
Back to 1.46.0:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.