Skip to content

Add migration for concurrent-download-chunk-size in container-runtime #4638

Merged
KCSesh merged 3 commits intobottlerocket-os:developfrom
KCSesh:add-chunk-size
Sep 9, 2025
Merged

Add migration for concurrent-download-chunk-size in container-runtime #4638
KCSesh merged 3 commits intobottlerocket-os:developfrom
KCSesh:add-chunk-size

Conversation

@KCSesh
Copy link
Contributor

@KCSesh KCSesh commented Sep 9, 2025

Description of changes:

Testing done:
Re-ran migration with released core-kit.

Tested migration: 1.46.0 -> 1.47.0 -> 1.46.0 on a custom eks-1.33 with containerd-2.1, and on aws-eks-1.32 (where the setting is a no-op)

1.46.0:

[ssm-user@control]$ apiclient set settings.container-runtime.concurrent-download-chunk-size="32mib"
Failed to change settings: Failed PATCH request to '/settings/keypair?tx=apiclient-set-sSym2oNqz9megGUk': Status 400 when PATCHing /settings/keypair?tx=apiclient-set-sSym2oNqz9megGUk: Unable to match your input to the data model.  We may not have enough type information.  Please try the —json input form.  Cause: Error during deserialization: unknown field concurrent-download-chunk-size, expected one of max-container-log-line-size, max-concurrent-downloads, enable-unprivileged-ports, enable-unprivileged-icmp, snapshotter at line 1 column 54

moved to 1.47.0:

[root@admin]#  apiclient set settings.container-runtime.concurrent-download-chunk-size="32mib"
[root@admin]# apiclient get settings.container-runtime.concurrent-download-chunk-size
{
  "settings": {
    "container-runtime": {
      "concurrent-download-chunk-size": 33554432
    }
  }
}

Back to 1.46.0:

[ssm-user@control]$ apiclient get settings.container-runtime.concurrent-download-chunk-size
{}
[ssm-user@control]$ apiclient get settings.container-runtime
{}

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@KCSesh KCSesh changed the title Add chunk size Add migration for concurrent-download-chunk-size in container-runtime Sep 9, 2025
@KCSesh KCSesh marked this pull request as ready for review September 9, 2025 20:48
Copy link
Contributor

@koooosh koooosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from removing the maplit.workspace = true dependency

Signed-off-by: Kyle Sessions <kssessio@amazon.com>
Signed-off-by: Kyle Sessions <kssessio@amazon.com>
Signed-off-by: Kyle Sessions <kssessio@amazon.com>
@KCSesh KCSesh merged commit 65616cf into bottlerocket-os:develop Sep 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants