Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small clarification and md cleanup #853

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Small clarification and md cleanup #853

merged 1 commit into from
Aug 22, 2021

Conversation

FranzEricSchneider
Copy link
Contributor

  1. Added the small "top-level gtsam directory" clarification because for a few minutes I thought it was saying to do this build process inside of the examples directory, which didn't work.
  2. Cleaned up the ## because without the space between icon and text it does not make a heading as intended. What the README looks like on develop at the moment:

Screenshot from 2021-08-21 17-02-11

@ProfFan
Copy link
Collaborator

ProfFan commented Aug 21, 2021

@FranzEricSchneider Thanks! Could you also add the proper headers to the code examples?

@FranzEricSchneider
Copy link
Contributor Author

@ProfFan sorry, I'm not quite sure what you mean. Could you elaborate? What would make a proper header? And which examples do you want it added to?

@dellaert
Copy link
Member

@ProfFan sorry, I'm not quite sure what you mean. Could you elaborate? What would make a proper header? And which examples do you want it added to?

I also don’t know what Fan means :-)

@ProfFan
Copy link
Collaborator

ProfFan commented Aug 22, 2021

@FranzEricSchneider Sorry I mistook this PR to be in the gtsam.org repo :(

In #852 (comment) you talked about the examples missing the headers they require. I am saying that you could add them in this PR.

@dellaert dellaert merged commit 1478936 into borglab:develop Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants