Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python fisheye interface #811

Merged
merged 26 commits into from
Jul 14, 2021

Commits on Jul 8, 2021

  1. Forward declaration for Set of Fisheye Cameras

    Forward declaration of camera vector for PinholeCamera<Cal3Fisheye> and PinholeCamera<Cal3Unified>.
    roderick-koehle authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    9967c59 View commit details
    Browse the repository at this point in the history
  2. Extend python wrapper to include fisheye models.

    Extend python wrapper to include fisheye camera models Cal3Fisheye and Cal3Unified.
    roderick-koehle authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    dfd50f9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from roderick-koehle/patch-3

    Extend python wrapper to include fisheye models.
    roderick-koehle authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    03e2744 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2 from roderick-koehle/patch-2

    Forward declaration for Set of Fisheye Cameras
    roderick-koehle authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    73d40a5 View commit details
    Browse the repository at this point in the history
  5. Forward declaration of fisheye camera.

    Forward declaration of PinholeCal3Fisheye needed by Python wrapper.
    roderick-koehle authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    55c1274 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c8fc3cd View commit details
    Browse the repository at this point in the history
  7. Extend unit testing of omnidirectional projection

    Test projection function and factors using a stereoscopic (xi=1) reference model, i.e the image height is given by y = 2 f tan(theta/2).
    roderick-koehle authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    19e8cde View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Introduce setUpClass, python snake_case variables

    Test case fails if object depth z is not equal 1.
    roderick-koehle authored Jul 9, 2021
    Configuration menu
    Copy the full SHA
    bdeb606 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6205057 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a411b66 View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    66af007 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2021

  1. Add comment about initial guess in undistortion

    For the equidistant fisheye model, r/f = tan(theta), the Gauss-Newton search to model radial distortion is expected to converge faster by mapping the angular coordinate space into the respective tangent space of the perspective plane. This is consistent to the nPlaneToSpace initial projection used in the calibrate() function of the omnidirectional model (Cal3Unified).
    roderick-koehle authored Jul 10, 2021
    Configuration menu
    Copy the full SHA
    0304992 View commit details
    Browse the repository at this point in the history
  2. Add ambiguous calibrate/uncalibrate declarations.

    Without declaring calibrate / uncalibrated in the interface specification, the functions of the Base class Cal3DS2_Base is called.
    The layout of the optional Jacobian matrix is 2x10 in Cal3Unified and 2x9 in Cal3DS2_Base, so this are different function calls.
    roderick-koehle authored Jul 10, 2021
    Configuration menu
    Copy the full SHA
    d54e234 View commit details
    Browse the repository at this point in the history
  3. Missing CameraSet binding specialisations

    Add pybind specialisations for CameraSetCal3Unified and CameraSetCal3Fisheye.
    roderick-koehle authored Jul 10, 2021
    Configuration menu
    Copy the full SHA
    3118fde View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0a73961 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. Testing CameraSet and triangulatePoint3

    Currently triangulatePoint3 returns wrong results for fisheye models. The template for PinholePose may be implemented for a fixed size of variable dimensions.
    roderick-koehle authored Jul 11, 2021
    Configuration menu
    Copy the full SHA
    941594c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c595767 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Configuration menu
    Copy the full SHA
    f53f5db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3402e46 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    17c37de View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3e41ece View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d130387 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Configuration menu
    Copy the full SHA
    305521e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    16cfc7f View commit details
    Browse the repository at this point in the history
  3. Remove comment

    roderick-koehle authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    c2bbe78 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a115788 View commit details
    Browse the repository at this point in the history